[Openib-windows] RE: User verbs

Fabian Tillier ftillier at silverstorm.com
Mon Mar 6 15:15:18 PST 2006


On 3/2/06, Leonid Keller <leonid at mellanox.co.il> wrote:
> Hi, Fab
>
> I send you a patch, regarding the calling of create_cq and alloc_pd with
> appropriate CA handle.
> The patch contains a little fix in al_verbs.h and appropriate changes in
> the driver, so that both drivers - the current and the new - can work
> with the same IBAL.
> In some days I'm going to change the implementation of tools support
> (=burning) to make it safe. I'll look through your comments on my first
> omplementation and check your suggestion about passing UM CA handle to
> vendor_call, so it can save resource_tracking info therein.
>
> Index: S:/svn.wininf/trunk/hw/mt23108/kernel/hca_data.h
> ===================================================================
> --- S:/svn.wininf/trunk/hw/mt23108/kernel/hca_data.h    (revision 439)
> +++ S:/svn.wininf/trunk/hw/mt23108/kernel/hca_data.h    (revision 1031)
> @@ -212,7 +212,7 @@
>        HH_hca_hndl_t           hh_hndl;
>        HH_hca_dev_t            dev_info;
>        uint8_t                         ul_hca_res[1];  // Beginning of
> UL resource buffer.
> -
> +       mlnx_hob_t                              *hob_p;

This is incorrect - the ul_hca_res byte is just the first byte of the
user-mode resource information.  The hob_p where you have it
overwrites part of this structure.

The UVPD expects the dev_info and UL resources to be contiguous, so I
moved hob_p up above dev_info.

- Fab



More information about the ofw mailing list