[Openib-windows] [PATCH] create av pd check

Yossi Leybovich sleybo at mellanox.co.il
Sat Mar 11 22:08:55 PST 2006


 

> -----Original Message-----
> From: ftillier.sst at gmail.com [mailto:ftillier.sst at gmail.com] 
> On Behalf Of Fabian Tillier
> Sent: Thursday, March 09, 2006 8:14 PM
> To: Yossi Leybovich
> Cc: openib-windows at openib.org
> Subject: Re: [Openib-windows] [PATCH] create av pd check
> 
> Hi Yossi,
> 
> On 3/9/06, Yossi Leybovich <sleybo at mellanox.co.il> wrote:
> > Fab
> >
> > I think we need to check pd in craete av ( like we check 
> CA, and other
> > handles) ?
> 
> Yes, there should be a check.
> 
> > If yes this patch add the check.
> 
> Thanks.  I'm actually thinking of changing all these checks 
> to assertions, and only having runtime checks in the proxy to 
> make sure user-mode doesn't do anything bad.  We have debug 
> versions that can be used to make sure invalid handles aren't 
> passed in.
> 
> What do you think?
> 


I don't think that there is performance problem on the control flow
(maybe on modify QP verbs we havce), but it will be nice to remove some
overhead of checks from release mode. 
> - Fab
> 
> 
> 



More information about the ofw mailing list