[Openib-windows] IBAL fixes for memfree driver
Fabian Tillier
ftillier at silverstorm.com
Wed Mar 15 09:21:05 PST 2006
> > > @@ -8968,21 +9013,23 @@
> > > ib_wc_status_t status;
> > > uint64_t vendor_specific;
> > >
> > > + uint32_t qp_num;
> > > +
> >
> > Can this be the user's QP context, rather than the QP number?
> > The QP number doesn't do much for the user unless they keep
> > a lookup table of QPN to whatever context they set when they
> > created the QP.
>
> This field is now used for one mode of sending MADs, that we don't use now.
> I'd rather delete it, but it would require to delete all the mode, so I kept it for the time being.
Let's supress the qp number internally to the MTHCA driver, then - if
there's no use of the field, then let's not add it. It shouldn't be
hard to supress and avoids having to change the API again when we
cleanup the driver to eliminate dead code.
In general, let's not distrurb the APIs just for the sake of
simplifying a porting effort. While it might save you a few minutes
of development work it is not the right way to do things.
- Fab
More information about the ofw
mailing list