[Openib-windows] IBAL fixes for memfree driver
Fabian Tillier
ftillier at silverstorm.com
Wed Mar 15 09:23:54 PST 2006
Hi Leonid,
After receiving the patch in your latest attachment, here are a few
extra comments.
On 3/7/06, Leonid Keller <leonid at mellanox.co.il> wrote:
>
> Index: ib_types.h
> ===================================================================
> --- ib_types.h (revision 230)
> +++ ib_types.h (working copy)
>
> @@ -8968,21 +9013,23 @@
> ib_wc_status_t status;
> uint64_t vendor_specific;
>
> + uint32_t qp_num;
> +
> union _wc_recv
> {
> struct _wc_conn
> {
> - ib_recv_opt_t recv_opt;
> + ib_recv_opt_t recv_opt;
You changed the whitespace here, likely to make things line up in your
environment. The whole code base is setup for tab width of 4, so
please avoid doing this if you're using some other tab width.
> ib_net32_t immediate_data;
>
> } conn;
>
> struct _wc_ud
> {
> - ib_recv_opt_t recv_opt;
> + ib_recv_opt_t recv_opt;
Same.
> ib_net32_t immediate_data;
> ib_net32_t remote_qp;
> - uint16_t pkey_index;
> + uint16_t pkey_index;
Same.
Thanks,
- Fab
More information about the ofw
mailing list