[Openib-windows] [PATCH] proxy_mad_recv_cb

Yossi Leybovich sleybo at mellanox.co.il
Wed Mar 29 00:24:22 PST 2006


Fab 
 
runnning under driver verifier found bug in 
_proxy_mad_recv_cb
 
in error flow the function try to release spinlock that it never aquired
here is patch that fix the problem 
 
Singed-off-by: Yossi Leybovich (sleybo at mellanox.co.il)
Index: core/al/kernel/al_proxy_subnet.c
===================================================================
--- core/al/kernel/al_proxy_subnet.c (revision 1170)
+++ core/al/kernel/al_proxy_subnet.c (working copy)
@@ -697,7 +697,11 @@
   * we're cleaning up the callback lists.
   */
  if( !proxy_context_ref( p_context ) )
-  goto proxy_mad_recv_cb_err;
+ {
+  proxy_put_mad( p_mad_element );
+  CL_EXIT( ( AL_DBG_PROXY_CB | AL_DBG_MAD ), g_al_dbg_lvl );
+  return;
+ }
 
  /* Insert an item to track the MAD until the user fetches it. */
  cl_spinlock_acquire( &p_context->h_al->obj.lock );

-------------- next part --------------
A non-text attachment was scrubbed...
Name: proxy_recv_cb.patch
Type: application/octet-stream
Size: 609 bytes
Desc: proxy_recv_cb.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20060329/5add5510/attachment.obj>


More information about the ofw mailing list