[Openib-windows] [PATCH] MTHCA: UVP error WC need to indicate the type of WC

[Fab Tillier]

Hi Leo,

Currently the MTHCA UVP will leave the WC type zero if the WC was completed in
error.  This breaks the WSD provider since it needs to know what type completion
are so that it can properly report them to the WSD switch.

The change here matches the code in the kernel MTHCA driver.

Thanks,

- Fab

Index: hw/mthca/user/mlnx_uvp_cq.c
===================================================================
--- hw/mthca/user/mlnx_uvp_cq.c	(revision 257)
+++ hw/mthca/user/mlnx_uvp_cq.c	(working copy)
@@ -356,13 +356,6 @@
 		wq->last_comp = wqe_index;
 	}
 
-	if (is_error) {
-		err = handle_error_cqe(cq, *cur_qp, wqe_index, is_send,
-				       (struct mthca_err_cqe *) cqe,
-				       entry, &free_cqe);
-		goto out;
-	}
-
 	if (is_send) {
 		entry->recv.ud.recv_opt = 0;
 		switch (cqe->opcode) {
@@ -429,8 +422,15 @@
 			IB_RECV_OPT_GRH_VALID : 0;
 	}
 
-	entry->status = IB_WCS_SUCCESS;
 
+	if (is_error) {
+		err = handle_error_cqe(cq, *cur_qp, wqe_index, is_send,
+				       (struct mthca_err_cqe *) cqe,
+				       entry, &free_cqe);
+	}
+	else
+		entry->status = IB_WCS_SUCCESS;
+
 out:
 	if (likely(free_cqe)) {
 		set_cqe_hw(cqe);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mthca_uvp_cq.patch
Type: application/octet-stream
Size: 842 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20060329/a2b95b78/attachment.obj>