[Openib-windows] [PATCH] WPP support for IPoIB

[Yossi Leybovich]

> -----Original Message-----
> From: ftillier.sst at gmail.com [mailto:ftillier.sst at gmail.com] 
> On Behalf Of Fabian Tillier
> Sent: Tuesday, May 09, 2006 3:00 AM
> To: Yossi Leybovich
> Cc: openib-windows at openib.org
> Subject: Re: [Openib-windows] [PATCH] WPP support for IPoIB
> 
> Hi Yossi,
> 
> On 5/2/06, Yossi Leybovich <sleybo at mellanox.co.il> wrote:
> > Fab
> >
> > This patch add WPP support to IPoIB
> > To activate WPP all you  need is to define 
> ENABLE_EVENT_TRACING in the 
> > SOURCE file ( this flag is set in fre version ) In chk 
> version we are 
> > back to the regular debug prints.
> 
> I applied this with the following changes:
> 
> - made edited lines less than 80 characters
> - use CL_TRACE macros in non-WPP case so that output is 
> consistent with previous stuff.  The IPOIB macros check the 
> level, and then call the complib debug macros for the actual 
> output.  This means the entry/exit marker is the square 
> bracket [ and ], respectively, instead of '===>' and '<===', 
> so that it is consistent with the output from the rest of the 
> stack when it uses the CL macros.  I did make a change so 
> that the module name (IPOIB) is displayed with each line of 
> debug output generated by the driver.

It will be helpful if the prints we see in WPP will be identical to the
prints in chk version.
That means that we need to change WPP to use [ and ] to ENTER/EXIT
functions.
We also need to add IPoIB to the start of each massage.

> - renamed IPOIB_DBG_ALL to IPOIB_DBG_ERROR in the WPP levels, 
> since it was only ever used for error prints.

The name is fine I thought this the right name just after I sent the
patch.
The only problem I can see with that is that in the WPP IPOIB_DBG_ERROR
use bit 0 and in the chk version it use bit 31.
It will be better if we will be consistent with both WPP and chk version
, 
this will enable us to use the same mask to fre and chk versions and
don't confuse with different bit order.
Can we move the IPOIB_DBG_ERROR to be the first bit ( and not use the
CL_ERROR bit) ?

BTW 
If you choose to use the 31 bit need to change the inf to set it.

> - changed all error prints (those that use TRACE_LEVEL_ERROR) 
> to use the IPOIB_DBG_ERROR flag only.
> 
> This is all committed in revision 335.  Let me know if you 
> see any issues.
> 

I found bug when compiling to 64 bit (fre version), 
the WPP is more strict in checking the print string format so we need to
use casting.
I will send patch on that.

> Thanks,
> 
> - Fab
> 
> 
>