[Openib-windows] [PATCH] IPOIB WPP

Yossi Leybovich sleybo at mellanox.co.il
Mon May 15 08:30:43 PDT 2006


Fab 

This patch make the prints in fre and chk version use the same prefix
and suffix
I also think that PRINT_EXIT should check the level of the traces 
because there might be cases that the level is error and the flag is not
error.
 
As I said I think its prefer to move the IPOIB_DBG_ERROR to bit 0 (keep
the same semantic between fre and chk)

10x
Yossi 
 
 
Singed-off-by: Yossi Leybovich (sleybo at mellanox.co.il)
Index: ipoib_debug.h
===================================================================
--- ipoib_debug.h (revision 1336)
+++ ipoib_debug.h (working copy)
@@ -83,11 +83,11 @@
 // begin_wpp config
 // IPOIB_ENTER(FLAG);
 // IPOIB_EXIT(FLAG);
-// USEPREFIX(IPOIB_PRINT, "%!STDPREFIX!%!FUNC!() :");
-// USEPREFIX(IPOIB_PRINT_EXIT, "%!STDPREFIX!%!FUNC!() :");
-// USESUFFIX(IPOIB_PRINT_EXIT, "\n %!FUNC!():<===");
-// USESUFFIX(IPOIB_ENTER, " %!FUNC!():===>");
-// USESUFFIX(IPOIB_EXIT, " %!FUNC!():<===");
+// USEPREFIX(IPOIB_PRINT, "%!STDPREFIX! [IPoIB] :%!FUNC!() :");
+// USEPREFIX(IPOIB_PRINT_EXIT, "%!STDPREFIX! [IPoIB] :%!FUNC!() :");
+// USESUFFIX(IPOIB_PRINT_EXIT, "[IpoIB] :%!FUNC!():]");
+// USESUFFIX(IPOIB_ENTER, " [IPoIB] :%!FUNC!():[");
+// USESUFFIX(IPOIB_EXIT, " [IPoIB] :%!FUNC!():]");
 // end_wpp
 
 #else
@@ -126,9 +126,9 @@
 
 #define IPOIB_PRINT_EXIT(_level_,_flag_,_msg_) \
  { \
-  UNREFERENCED_PARAMETER( _level_ ); \
-  if( g_ipoib_dbg_level >= TRACE_LEVEL_VERBOSE ) \
-   CL_TRACE_EXIT( _flag_, g_ipoib_dbg_flags, _msg_ ); \
+  if( g_ipoib_dbg_level >= (_level_) ) \
+   CL_TRACE( _flag_, g_ipoib_dbg_flags, _msg_ );\
+  IPOIB_EXIT(_flag_);\
  }
 
 #define IPOIB_ENTER(_flag_) \

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ipoib_wpp2.patch
Type: application/octet-stream
Size: 1237 bytes
Desc: ipoib_wpp2.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20060515/552d6a74/attachment.obj>


More information about the ofw mailing list