[Openib-windows] Creating shared memory for performance counters

[Tzachi Dar]

Checked in revision 365.

Thanks
Tzachi 

> -----Original Message-----
> From: ftillier.sst at gmail.com [mailto:ftillier.sst at gmail.com] 
> On Behalf Of Fabian Tillier
> Sent: Thursday, May 25, 2006 8:44 PM
> To: Tzachi Dar
> Cc: openib-windows at openib.org
> Subject: Re: [Openib-windows] Creating shared memory for 
> performance counters
> 
> Hi Tzachi,
> 
> On 5/25/06, Tzachi Dar <tzachid at mellanox.co.il> wrote:
> >
> > Hi Fab,
> >
> > In the function IBSPPmInit the code checks if this shared 
> memory was 
> > just created by using
> >
> > just_created = (GetLastError() != ERROR_ALREADY_EXISTS);
> >
> > However, as localfree might change the GetLastError value, 
> this line 
> > should be moved two lines up (Just after CreateFileMapping).
> 
> I think the current code will work because if we get that 
> far, LocalFree must succeed (unless we have serious memory 
> corruption).
> Never the less, your suggestion is certainly more correct.  
> Would you mind making the change and committing it?
> 
> Thanks,
> 
> - Fab
> 
> 
>