[Openib-windows] [SRP] patch handling session connection failure.

Estrin, Alex aestrin at silverstorm.com
Fri Oct 27 10:01:40 PDT 2006


Yossi,
 
Please review the following patch.
It fixes possible situation when rearm CQ fails and connect requester stuck to wait event signal forever.
 
Thanks,
Alex
 
Index: srp_connection.c
===================================================================
--- srp_connection.c (revision 525)
+++ srp_connection.c (working copy)
@@ -555,7 +555,8 @@
    ("ib_rearm_cq() for send cq failed!, status 0x%x", status) );
 
   // TODO: Kill session and inform port driver link down storportnotification
-  return;
+  p_connection->state = SRP_CONNECT_FAILURE;
+  goto exit;
  }
 
  status = p_ifc->rearm_cq( p_connection->h_recv_cq, FALSE );
@@ -565,7 +566,7 @@
    ("ib_rearm_cq() for recv failed!, status 0x%x", status) );
 
   // TODO: Kill session and inform port driver link down storportnotification
-  return;
+  p_connection->state = SRP_CONNECT_FAILURE;
  }
 
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20061027/ffd8f104/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: srp_connection.patch
Type: application/octet-stream
Size: 722 bytes
Desc: srp_connection.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20061027/ffd8f104/attachment.obj>


More information about the ofw mailing list