[Openib-windows] [PATCH] IPoIB response to 1x links

Fabian Tillier ftillier at silverstorm.com
Tue Sep 5 11:43:15 PDT 2006


Hi Yossi,

On 9/4/06, Yossi Leybovich <sleybo at mellanox.co.il> wrote:
> Fab
>
> One of our verification engineers generate the following scenario.
>
> -phy link down
> -link speed set to 1x
> -phy link up
>
> -phy link down
> -link speed set to 4x
> -phy link up
>
> And he got blue screen in the IPOIB .

<snip>

> As you can see from the ASSERT we insert the local port twice.
> The reason is that in set_port_inactive we change the adapter state to
> down (and resume oids) but we don't clear the endpnt.
> The following patch add call to __reset_enpt any time we call
> set_inactive.
> The patch fix the problem.
> ( I thought to call ipoib_port_down from with in the function
> set_inactive but we call it from DPC level and port_down is waiting on
> the sa_event)

The patch looks good except for the lack of space around the
parentheses.  There should be a space before and after 'p_port'.

Aside from that the code looks good to commit so go ahead and check it in.

Thanks,

- Fab




More information about the ofw mailing list