[Openib-windows] SRP __ioc_query_sa error flow

Yossi Leybovich sleybo at mellanox.co.il
Wed Sep 6 03:13:41 PDT 2006


Fab 
 
In the begging of __ioc_query_sa function you check 
if( p_svc->h_node_query )
  return IB_NOT_DONE;

 if( p_svc->h_path_query )
  return IB_NOT_DONE;

 I think that when ib_query fail we should set p_svc->h_node_query =
NULL so in the next time the sweep will try to query this mad_svc (this
port).
The current code does not do  that 
 

 status = ib_query( gh_al, &query, &p_svc->h_node_query );
 if( status != IB_SUCCESS )
 {
  cl_atomic_dec( &p_svc->query_cnt );
  deref_al_obj( &p_svc->obj );
  AL_PRINT_EXIT( TRACE_LEVEL_WARNING, AL_DBG_PNP,
   ("ib_query returned %s\n", ib_get_err_str( status )) );
  return status;
 }

 
What do you think ?
 
Yossi 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20060906/26561d5c/attachment.html>


More information about the ofw mailing list