[ofw] port_attr structure

[Fab Tillier]

If you do change the structure, unless it's adding fields to the end of
the structure, you'll need to increment the version of the interface so
that clients that expect the old format fail properly.

 

-Fab

 

From: ofw-bounces at lists.openfabrics.org
[mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Yossi Leybovich
Sent: Sunday, February 18, 2007 11:18 PM
To: Fab Tillier
Cc: ofw at lists.openfabrics.org
Subject: RE: [ofw] port_attr structure

 

Thanks.

I thought about embedding the structure to the port attr but it will
require changing all ULPs.

I will see what is the effort of the change.

 

Yossi 

 

 

 

	 

________________________________

	From: Fab Tillier [mailto:ftillier at windows.microsoft.com] 
	Sent: Monday, February 19, 2007 7:57 AM
	To: Yossi Leybovich
	Cc: ofw at lists.openfabrics.org
	Subject: RE: [ofw] port_attr structure

	Hi Yossi,

	 

	There's no issue including the full port info in the port_attr
structure.  Initially the structure was setup to return commonly used
information.  It was not intended to be identical to the IB spec port
info.  I would recommend embedding the port_info structure into the
port_attr, instead of copying the fields.

	 

	-Fab

	 

	From: ofw-bounces at lists.openfabrics.org
[mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Yossi Leybovich
	Sent: Sunday, February 18, 2007 4:52 AM
	To: Fab Tillier
	Cc: ofw at lists.openfabrics.org
	Subject: [ofw] port_attr structure

	 

	Hi

	 

	I want to add more info to the port_attr structure (like link
width enable, link width enable).

	I notice that the port_attr include only specific fields from
the port info structure of the IB spec.

	Is there any reason why the port_attr structure in IBAL is
different from the IB spec port info (or at least include all its
fields)

	 

	Yossi 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20070219/5346b41c/attachment.html>