[ofw][IBAL] patch for pool corruption

Alex Estrin alex.estrin at qlogic.com
Mon Mar 5 08:31:05 PST 2007



> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org [mailto:ofw-
> bounces at lists.openfabrics.org] On Behalf Of Alex Estrin
> Sent: Monday, March 05, 2007 9:36 AM
> To: Yossi Leybovich
> Cc: ofw at lists.openfabrics.org
> Subject: RE: [ofw][IBAL] patch for pool corruption
> 
> Hi,
> 
> > -----Original Message-----
> > From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> > Sent: Sunday, March 04, 2007 2:25 AM
> > To: Alex Estrin
> > Cc: ofw at lists.openfabrics.org
> > Subject: RE: [ofw][IBAL] patch for pool corruption
> >
> > Hi
> >
> > Do you know why ven_id 0x66a ( former SilverStorm ) need special
> > treatment for the location query?
> No, I don't know yet.
It seem passing through id_string is the only way to provide actual IO
Unit geographical position(slot number) within chassis architectures
accepting multiple IOUnits.
> > Can you use id_string in the query_description ?
> >
> > Can we just use the same code for all IOCs
> I guess we can.
> > Yossi
> >
> >
> > > -----Original Message-----
> > > From: Alex Estrin [mailto:alex.estrin at qlogic.com]
> > > Sent: Friday, March 02, 2007 5:30 PM
> > > To: Yossi Leybovich
> > > Cc: ofw at lists.openfabrics.org
> > > Subject: [ofw][IBAL] patch for pool corruption
> > >
> > > Hi Yossi,
> > >
> > > This patch should fix potential pool corruption.
> > > Please review.
> > >
> > > Thanks,
> > > Alex
> > >
> > > Index: iou_ioc_mgr.c
> > >
===================================================================
> > > --- iou_ioc_mgr.c	(revision 599)
> > > +++ iou_ioc_mgr.c	(working copy)
> > > @@ -1142,7 +1142,9 @@
> > >  		return STATUS_NO_SUCH_DEVICE;
> > >  	}
> > >
> > > -	p_string = ExAllocatePool( PagedPool, IOC_LOCATION_SIZE );
> > > +	p_string = ExAllocatePool( PagedPool,
> > > +		max( IOC_LOCATION_SIZE,
> > > +		sizeof( WCHAR ) * ( sizeof(
> > > p_ext->info.profile.id_string ) + 1 )));
> > >  	if( !p_string )
> > >  	{
> > >  		IOU_PRINT_EXIT( TRACE_LEVEL_ERROR, IOU_DBG_ERROR,
> > >
> > >
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw



More information about the ofw mailing list