[ofw] [PATCH] reset completion

[Tzachi Dar]

Hi Slava,
 
your patch is trying to fix the contract between ipoib_reset and the
function ipoib_reset_adapter.
 
Indeed, ipoib_reset calls ipoib_reset_adapter and based on it's return
value decides if to return NDIS_STATUS_PENDING or not.
 
So adding the lines 
+          if (status == IB_NOT_DONE)

+                      p_adapter->reset = TRUE;

+          else

+                      p_adapter->reset = FALSE;

+

seems very reasonable.

 

On the other hand when trying to understand the bigger picture, than I
guess that I still have a question. I wander if you or anyone else
knows:

 

What is the result that we want to return when p_adapter->h_pnp is not
present? In that case, we would simply start registration with the pnp
but return NDIS_STATUS_SUCCESS to NDIS. This tells NDIS that we are
ready, although we are not. Is this really what we want?

 

Thanks

Tzachi

 


________________________________

	From: ofw-bounces at lists.openfabrics.org
[mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Slava Strebkov
	Sent: Tuesday, April 01, 2008 5:09 PM
	To: ofw at lists.openfabrics.org
	Subject: [ofw] [PATCH] reset completion
	
	

	 

	Hi,

	We got a bugcheck when NdisMResetComplete called without
previous reset request completed with STATUS_PENDING.

	The following patch fixes the bug.

	 

	Index: ulp/ipoib/kernel/ipoib_adapter.c

	
===================================================================

	--- ulp/ipoib/kernel/ipoib_adapter.c          (revision 1026)

	+++ ulp/ipoib/kernel/ipoib_adapter.c       (working copy)

	@@ -808,6 +808,11 @@

	                                    p_adapter->hung = FALSE;

	            }

	 

	+          if (status == IB_NOT_DONE)

	+                      p_adapter->reset = TRUE;

	+          else

	+                      p_adapter->reset = FALSE;

	+

	            IPOIB_EXIT( IPOIB_DBG_INIT );

	            return status;

	 }

	 

	 

	Slava Strebkov

	SW Engineer

	Voltaire

	099718750

	 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080401/573665e5/attachment.html>