[ofw] [PATCH] core [1/5]

[Sean Hefty]

Thanks for keeping each patch easily reviewable.

 

As a general comment regarding the patches that you've submitted, in the future
please add a brief comment in the email subject regarding the nature of patch.
Something like:

 

[PATCH 1/5] core/ibal: print port guid

 

In the email body, provide a more detailed description of what the patch does
and why for patches that are not trivial.  For the patch below, you don't really
need much beyond the email subject, but for some of the other patches, the
descriptions aren't enough to figure out what's being done and why.

 

Thanks

- Sean

 

Hi,

 

The following patch adds port guid to the print

 

Thanks, Reuven.

 

Index: core/al/kernel/al_sa_req.c

===================================================================

--- core/al/kernel/al_sa_req.c     (revision 1047)

+++ core/al/kernel/al_sa_req.c     (working copy)

@@ -627,7 +627,7 @@

     p_sa_req->p_sa_req_svc = acquire_sa_req_svc( port_guid );

     if( !p_sa_req->p_sa_req_svc )

     {

-          AL_PRINT_EXIT( TRACE_LEVEL_INFORMATION, AL_DBG_QUERY, ("invalid port
GUID\n") );

+          AL_PRINT_EXIT( TRACE_LEVEL_INFORMATION, AL_DBG_QUERY, ("invalid port
GUID %#I64x\n", port_guid) );

           return IB_INVALID_GUID;

     }

 

 

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080410/695fe265/attachment.html>