[ofw] [PATCH] core [3/5]

[Sean Hefty]

Index: core/al/al_qp.c

===================================================================

--- core/al/al_qp.c    (revision 1047)

+++ core/al/al_qp.c    (working copy)

@@ -327,8 +327,8 @@

           }

           status = init_conn_qp( (al_conn_qp_t*)h_qp, h_pd, p_qp_create,
p_umv_buf );

 #ifdef CL_KERNEL

-          if( NT_SUCCESS( status ) )

-                status = ndi_qp_init( h_qp );

+          if( status == IB_SUCCESS && !NT_SUCCESS( ndi_qp_init(h_qp) ) )

+                status = IB_ERROR;

 

It makes more sense to me to keep the return value reported by ndi_qp_init,
rather than always setting it to IB_ERROR.

 

 #endif

           break;

 

Index: core/al/kernel/al_ndi_cm.c

===================================================================

--- core/al/kernel/al_ndi_cm.c     (revision 1047)

+++ core/al/kernel/al_ndi_cm.c     (working copy)

@@ -436,6 +436,8 @@

 

     if ( h_qp->type == IB_QPT_UNRELIABLE_CONN )

     {

 

This is outside this patch, but this check would be better as a negative check
against the one type of QP that NDI does support.  What if the user passes in a
UD QP for example?

 

+          AL_PRINT( TRACE_LEVEL_INFORMATION, AL_DBG_NDI,

+                ("UC QP type is not supported \n"));

 

This would then change to say that only RC QP is supported by NDI.

 

           status = STATUS_SUCCESS;

           goto exit;

     }

 

- Sean

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080410/3a5b822f/attachment.html>