[ofw] Prefast patch

James Yang jyang at xsigo.com
Fri Apr 18 13:50:58 PDT 2008


Sure, feel free to change it back when it's checked in.

Thanks,
James


-----Original Message-----
From: Sean Hefty [mailto:sean.hefty at intel.com] 
Sent: Friday, April 18, 2008 1:01 PM
To: James Yang; ofw at lists.openfabrics.org
Subject: RE: [ofw] Prefast patch

-           ObReferenceObjectByHandle( h_user_wait_obj, STANDARD_RIGHTS_ALL,
-                       *ExEventObjectType, UserMode, (PVOID*)&h_kevent, NULL );
+          // Supressing Prefast Warning details are:
+          //          warning 8126 : The AccessMode parameter to
ObReferenceObject* should be IRP->RequestorMode..
+          //          Path includes 7 statements on the following lines:
+          #pragma prefast(suppress:8126, "Suprressing next line for Prefast
warning for reason mentioned above in comments")
+          ObReferenceObjectByHandle( h_user_wait_obj, STANDARD_RIGHTS_ALL,
*ExEventObjectType, UserMode, (PVOID*)&h_kevent, NULL );

There's no need to reformat the ObReferenceObjectByHandle() call.  The previous
formatting was more readable.  The change makes a single line 133 columns wide,
which scrolls off the edge of my screen.

- Sean





More information about the ofw mailing list