[ofw] RE: [REPOST] [PATCH] Add ND files

[Smith, Stan]

Hello,
  Thanks for delivering the nd binaries. Are there any licensing issues with redistribution?

 Just to make sure I understand from an install perspective, who/how/when & why is ndinstall.exe executed?

Why is nd so closely tied to IPoIB install?  Precludes nd as optional?

Why is nd not installed standalone independent of IPoIB? A WIX 'feature'?

I assume your intention is for nd to be a 'standard' feature of WinOF 2.0?

I assume ibndprov.dll is intended to be installed in %windir% ?

Could ndinstall.exe live in %ProgramFiles(x86)%\WinOF\ ?

Why is nd, an upper level protocol, not resident in trunk\ulp\nd\user ?
  Eventually the source for the nd provider will be in svn, so from a minimize modifications to WIX src files, why not place binaries where the src will live?  For the near term, we could construct a sources/makefile to copy .dll & .exe to trunk\bin\user\...

stan.

________________________________
From: Reuven Amitai [mailto:reuven at mellanox.co.il]
Sent: Wednesday, August 06, 2008 4:11 AM
To: Smith, Stan; Tzachi Dar; Fab Tillier
Cc: ofw at lists.openfabrics.org
Subject: RE: [REPOST] [PATCH] Add ND files

Hi,

The patch add ND files (ibndprov.dll, ndinstall.exe) to netipoib.inx, ipoib.cdf, ipoib32.cdf
Currently IA64 platform isn't supported (HPC supports Windows 2008 x64). netipoib-xp32.inf wasn't changed (same reason)
Attached nd-part.diff (diff for netipoib.inx, ipoib.cdf, ipoib32.cdf alone) and nd -bin .zip which contains ibndprov.dll and ndinstall.exe
(remove .zip suffix for each file). I think we should add them under trunk\etc\bin\ directory (new directory).
Do you have other suggestions for binaries file location in the svn tree?

Thanks, Reuven.

>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

Index: ipoib.cdf
===================================================================
--- ipoib.cdf     (revision 1466)
+++ ipoib.cdf     (working copy)
@@ -8,3 +8,6 @@
 <hash>ipoib.sys=ipoib.sys
 <hash>ibwsd.dll=ibwsd.dll
 <hash>ibwsd32.dll=ibwsd32.dll
+<hash>ibndprov.dll=ibndprov.dll
+<hash>ibndprov32.dll=ibndprov32.dll
+<hash>ndinstall.exe=ndinstall.exe
Index: ipoib32.cdf
===================================================================
--- ipoib32.cdf   (revision 1466)
+++ ipoib32.cdf   (working copy)
@@ -7,3 +7,6 @@
 <hash>netipoib.inf=netipoib.inf
 <hash>ipoib.sys=ipoib.sys
 <hash>ibwsd.dll=ibwsd.dll
+<hash>ibwsd.dll=ibwsd.dll
+<hash>ibndprov.dll=ibndprov.dll
+<hash>ndinstall.exe=ndinstall.exe
Index: netipoib.inx
===================================================================
--- netipoib.inx  (revision 1466)
+++ netipoib.inx  (working copy)
@@ -32,14 +32,16 @@
 Characteristics = 0x81 ; NCF_HAS_UI | NCF_VIRTUAL
 AddReg          = IpoibAddReg
 CopyFiles       = IpoibCopyFiles
-CopyFiles        = WsdCopyFiles
+CopyFiles       = WsdCopyFiles
+CopyFiles       = NdCopyFiles

 [Ipoib.DDInstall.ntamd64]
 Characteristics = 0x81 ; NCF_HAS_UI | NCF_VIRTUAL
 AddReg          = IpoibAddReg
 CopyFiles       = IpoibCopyFiles
-CopyFiles        = WsdCopyFiles
-CopyFiles        = WOW64CopyFiles
+CopyFiles       = WsdCopyFiles
+CopyFiles       = NdCopyFiles
+CopyFiles       = WOW64CopyFiles

 [Ipoib.DDInstall.ntia64]
 Characteristics = 0x81 ; NCF_HAS_UI | NCF_VIRTUAL
@@ -161,8 +163,13 @@
 [WsdCopyFiles]
 ibwsd.dll,,,0x00000002

+[NdCopyFiles]
+ibndprov.dll,,,0x00000002
+ndinstall.exe,,,0x00000002
+
 [WOW64CopyFiles]
 ibwsd.dll,ibwsd32.dll,,0x00000002
+ibndprov.dll,ibndprov32.dll,,0x00000002

 [SourceDisksNames.x86]
 1 = %IcsDisk1%,,,""
@@ -176,11 +183,16 @@
 [SourceDisksFiles.x86]
 ipoib.sys = 1
 ibwsd.dll = 1
+ibndprov.dll = 1
+ndinstall.exe = 1

 [SourceDisksFiles.amd64]
 ipoib.sys = 1
 ibwsd.dll = 1
 ibwsd32.dll = 1
+ibndprov.dll = 1
+ibndprov32.dll = 1
+ndinstall.exe = 1

 [SourceDisksFiles.ia64]
 ipoib.sys = 1
@@ -190,6 +202,7 @@
 [DestinationDirs]
 IpoibCopyFiles    = %DIRID_DRIVERS%
 WsdCopyFiles      = %DIRID_SYSTEM%
+NdCopyFiles       = %DIRID_SYSTEM%
 WOW64CopyFiles    = %DIRID_SYSTEM_X86%
 DefaultDestDir    = %DIRID_SYSTEM%


________________________________
From: Smith, Stan [mailto:stan.smith at intel.com]
Sent: Tuesday, July 29, 2008 9:55 PM
To: Reuven Amitai; Tzachi Dar; Fab Tillier
Cc: ofw at lists.openfabrics.org
Subject: RE: [Patch] Add ND files into Netipoib.inx

The only problem here not all of us have the ND files, hence will error out on install!
Please forward binaries and/or place binaries in svn until ND sources are available to build.

Please do not inject known broken patches into svn without suggesting a global fix for all.

thanks,

stan.

________________________________
From: Reuven Amitai [mailto:reuven at mellanox.co.il]
Sent: Tuesday, July 29, 2008 10:12 AM
To: Tzachi Dar; Smith, Stan; Fab Tillier
Cc: ofw at lists.openfabrics.org
Subject: [Patch] Add ND files into Netipoib.inx

Hi,

The patch add ND files to netipoib.inx since in the coming release ND will be part of WinOF.
IbNdProv.dll is the Provider dll, ndinstall.exe is ND installer.

Thanks, Reuven.

>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080806/6dc492f3/attachment.html>