[ofw] RE: [REPOST] [PATCH] Add ND files
Smith, Stan
stan.smith at intel.com
Thu Aug 7 10:09:04 PDT 2008
Thanks Leonid, some additional questions inline.
________________________________
From: Leonid Keller [mailto:leonid at mellanox.co.il]
Sent: Thursday, August 07, 2008 2:23 AM
To: Smith, Stan; Reuven Amitai; Tzachi Dar; Fab Tillier
Cc: ofw at lists.openfabrics.org
Subject: RE: [ofw] RE: [REPOST] [PATCH] Add ND files
see inline
________________________________
From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Smith, Stan
Sent: Thursday, August 07, 2008 12:45 AM
To: Reuven Amitai; Tzachi Dar; Fab Tillier
Cc: ofw at lists.openfabrics.org
Subject: [ofw] RE: [REPOST] [PATCH] Add ND files
Just to make sure I understand from an install perspective, who/how/when & why is ndinstall.exe executed?
[Leonid Keller] See ND as another flavour of WSD.
It has to be installed from MSI the same way as WSD upon user's request or by default.
The implication here is ndinstall.exe must be executed during the ND install, similar to WSD.
ndinstall.exe is not and should not be referenced in a .inf or .cat file; like installsp.exe.
Why is nd so closely tied to IPoIB install? Precludes nd as optional?
Why is nd not installed standalone independent of IPoIB? A WIX 'feature'?
I assume your intention is for nd to be a 'standard' feature of WinOF 2.0?
[Leonid Keller] ND, like WSD, requires IPoIB for its work.
But it tends to replace WSD, so, yes, we want it to be a standard feature.
Am I to assume that ND is limited to only those environments where WSD is supported?
Specifically, XP doesn't support WSD and should not support ND?
I assume ibndprov.dll is intended to be installed in %windir% ?
[Leonid Keller] In %windir%\system32 like all other dlls.
DAT/DAPL .dll files are installed in %windir%, was the reason for asking?
I was under the impression system32\ was for mainly driver files, with ibndprov.dll being a provider.
Should the DAT/DAPL files be relocated to system32?
Could ndinstall.exe live in %ProgramFiles(x86)%\WinOF\ ?
[Leonid Keller] It seems reasonable to put it in the same place with WSD stuff, especially instalsp.exe
Will install ndinstall.exe into WinOF\ folder
Why is nd, an upper level protocol, not resident in trunk\ulp\nd\user ?
[Leonid Keller] In our internal SVN tree it resides really there ...
Eventually the source for the nd provider will be in svn, so from a minimize modifications to WIX src files, why not place binaries where the src will live? For the near term, we could construct a sources/makefile to copy .dll & .exe to trunk\bin\user\...
[Leonid Keller] When the source comes, we'll remove the binaries ...
I'd suggest to put ND binaries in trunk\bin\..., i.e. in those same places, where they would come while generated from the source code.
ND binaries should live in trunk\ulp\nd\user along with SOURCES file to copy into trunk\bin\user\....
I'll set this up ASAP.
stan.
________________________________
From: Reuven Amitai [mailto:reuven at mellanox.co.il]
Sent: Wednesday, August 06, 2008 4:11 AM
To: Smith, Stan; Tzachi Dar; Fab Tillier
Cc: ofw at lists.openfabrics.org
Subject: RE: [REPOST] [PATCH] Add ND files
Hi,
The patch add ND files (ibndprov.dll, ndinstall.exe) to netipoib.inx, ipoib.cdf, ipoib32.cdf
Currently IA64 platform isn't supported (HPC supports Windows 2008 x64). netipoib-xp32.inf wasn't changed (same reason)
Attached nd-part.diff (diff for netipoib.inx, ipoib.cdf, ipoib32.cdf alone) and nd -bin .zip which contains ibndprov.dll and ndinstall.exe
(remove .zip suffix for each file). I think we should add them under trunk\etc\bin\ directory (new directory).
Do you have other suggestions for binaries file location in the svn tree?
Thanks, Reuven.
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
Index: ipoib.cdf
===================================================================
--- ipoib.cdf (revision 1466)
+++ ipoib.cdf (working copy)
@@ -8,3 +8,6 @@
<hash>ipoib.sys=ipoib.sys
<hash>ibwsd.dll=ibwsd.dll
<hash>ibwsd32.dll=ibwsd32.dll
+<hash>ibndprov.dll=ibndprov.dll
+<hash>ibndprov32.dll=ibndprov32.dll
+<hash>ndinstall.exe=ndinstall.exe
Index: ipoib32.cdf
===================================================================
--- ipoib32.cdf (revision 1466)
+++ ipoib32.cdf (working copy)
@@ -7,3 +7,6 @@
<hash>netipoib.inf=netipoib.inf
<hash>ipoib.sys=ipoib.sys
<hash>ibwsd.dll=ibwsd.dll
+<hash>ibwsd.dll=ibwsd.dll
+<hash>ibndprov.dll=ibndprov.dll
+<hash>ndinstall.exe=ndinstall.exe
Index: netipoib.inx
===================================================================
--- netipoib.inx (revision 1466)
+++ netipoib.inx (working copy)
@@ -32,14 +32,16 @@
Characteristics = 0x81 ; NCF_HAS_UI | NCF_VIRTUAL
AddReg = IpoibAddReg
CopyFiles = IpoibCopyFiles
-CopyFiles = WsdCopyFiles
+CopyFiles = WsdCopyFiles
+CopyFiles = NdCopyFiles
[Ipoib.DDInstall.ntamd64]
Characteristics = 0x81 ; NCF_HAS_UI | NCF_VIRTUAL
AddReg = IpoibAddReg
CopyFiles = IpoibCopyFiles
-CopyFiles = WsdCopyFiles
-CopyFiles = WOW64CopyFiles
+CopyFiles = WsdCopyFiles
+CopyFiles = NdCopyFiles
+CopyFiles = WOW64CopyFiles
[Ipoib.DDInstall.ntia64]
Characteristics = 0x81 ; NCF_HAS_UI | NCF_VIRTUAL
@@ -161,8 +163,13 @@
[WsdCopyFiles]
ibwsd.dll,,,0x00000002
+[NdCopyFiles]
+ibndprov.dll,,,0x00000002
+ndinstall.exe,,,0x00000002
+
[WOW64CopyFiles]
ibwsd.dll,ibwsd32.dll,,0x00000002
+ibndprov.dll,ibndprov32.dll,,0x00000002
[SourceDisksNames.x86]
1 = %IcsDisk1%,,,""
@@ -176,11 +183,16 @@
[SourceDisksFiles.x86]
ipoib.sys = 1
ibwsd.dll = 1
+ibndprov.dll = 1
+ndinstall.exe = 1
[SourceDisksFiles.amd64]
ipoib.sys = 1
ibwsd.dll = 1
ibwsd32.dll = 1
+ibndprov.dll = 1
+ibndprov32.dll = 1
+ndinstall.exe = 1
[SourceDisksFiles.ia64]
ipoib.sys = 1
@@ -190,6 +202,7 @@
[DestinationDirs]
IpoibCopyFiles = %DIRID_DRIVERS%
WsdCopyFiles = %DIRID_SYSTEM%
+NdCopyFiles = %DIRID_SYSTEM%
WOW64CopyFiles = %DIRID_SYSTEM_X86%
DefaultDestDir = %DIRID_SYSTEM%
________________________________
From: Smith, Stan [mailto:stan.smith at intel.com]
Sent: Tuesday, July 29, 2008 9:55 PM
To: Reuven Amitai; Tzachi Dar; Fab Tillier
Cc: ofw at lists.openfabrics.org
Subject: RE: [Patch] Add ND files into Netipoib.inx
The only problem here not all of us have the ND files, hence will error out on install!
Please forward binaries and/or place binaries in svn until ND sources are available to build.
Please do not inject known broken patches into svn without suggesting a global fix for all.
thanks,
stan.
________________________________
From: Reuven Amitai [mailto:reuven at mellanox.co.il]
Sent: Tuesday, July 29, 2008 10:12 AM
To: Tzachi Dar; Smith, Stan; Fab Tillier
Cc: ofw at lists.openfabrics.org
Subject: [Patch] Add ND files into Netipoib.inx
Hi,
The patch add ND files to netipoib.inx since in the coming release ND will be part of WinOF.
IbNdProv.dll is the Provider dll, ndinstall.exe is ND installer.
Thanks, Reuven.
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080807/a8131342/attachment.html>
More information about the ofw
mailing list