[ofw] RE: [RFC] Remove path query from IPoIB

Hefty, Sean sean.hefty at intel.com
Sun Aug 10 22:47:45 PDT 2008


>+               /*
>+                * Handle a race between the mcast callback and a receive/send.
>The QP
>+                * is joined to the MC group before the MC callback is
>received, so it
>+                * can receive packets, and NDIS can try to respond.  We need
>to delay
>+                * a response until the MC callback runs and sets the AV.
>+                */

Only a comment is being added here, but... why isn't the join delayed until after the MC callback is invoked and the AV created?  Or is the wrong race being described?

>@@ -402,38 +328,17 @@ __path_query_cb(
>         * for which there is no match, something that doesn't work when
>         * using LIDs only.
>         */
>-       flow_lbl = ib_path_rec_flow_lbl( p_path );
>        av_attr.grh_valid = TRUE;

I don't think we want grh_valid to always be true here, or we always send the GRH.

- Sean



More information about the ofw mailing list