[ofw] RE: [PATCH] IPoIB - add guid2mac table

[Reuven Amitai]

Hi,

Adding new rows will be less straight-forward. and binary search won't
improve (if not decrease) speed in the current table size.

Ipoib_mac_form_guid() is called in adapter initialization, in every DHCP
packet (initialization too), and in other sort of packets 
only if the remote endpoint is not known (only first packet may be
affected).

Thanks, Reuven.

-----Original Message-----
From: Sean Hefty [mailto:sean.hefty at intel.com] 
Sent: Monday, December 08, 2008 8:37 AM
To: Reuven Amitai; Tzachi Dar
Cc: ofw at lists.openfabrics.org
Subject: RE: [PATCH] IPoIB - add guid2mac table

>+const ipoib_guid2mac_translation_t guid2mac_table[] = {  {0x30, 0x48, 
>+0xE7},  {0x05, 0xAD, 0xE7},  {0x18, 0x8B, 0xE7},  {0x1A, 0x4B, 0xE7},

>+{0x17, 0x08, 0xE7},  {0x1E, 0x0B, 0xE7},
>+
>+ {0x00, 0x00, 0x00},
>+};

Why not sort the GUIDs, so that a binary search can be used instead?  Or
is this table never examined during any speed path operations?

- Sean