[ofw] RE: [ofa-general] PATCH[2/6] Windows port of libibmad - dump.c

[Hal Rosenstock]

On Thu, Dec 18, 2008 at 10:00 PM, Sean Hefty <sean.hefty at intel.com> wrote:
>>Did he reimplement IBWARN, IBPANIC, and all the sys_read_* functions?  I think
>>those come from ibcommon and are used by the diags.
>
> He added this to mad.h:
>
> #if !defined(IBWARN)
> #define IBWARN(fmt, ...) cl_msg_out(fmt, ## __VA_ARGS__)
> #endif
> #if !defined(IBPANIC)
> #define IBPANIC(fmt, ...) \
> { \
>        cl_msg_out(fmt, ## __VA_ARGS__); \
>        CL_ASSERT(0); \
> }
> #endif
>
> This allows libibcommon to exist on Linux,

Sasha has written some comments on the general list indicating that
libibcommon may disappear in the future. It could be combined with
libibumad (as libibmad (and diags) both use it.

-- Hal

> but eliminates it for Windows - for
> the diags.  (The diags don't use sys_read_*.)  I think this implementation
> requires a specific include order of header files though.
>
> - Sean
>
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
>