[ofw] WinVerbs v2

[Fab Tillier]

>>typedef struct _WV_CONNECT_PARAM
>>>{
>>>        const VOID*             pPrivateData;
>>
>>Is this buffer provided by the user when used as part of the WV_CONNECT_EVENT?
>>The usage of the event structures isn't clear.
>
>I was assuming that this would be allocated by the library and freed by the
>user.

That sounds like a good recipe for memory leaks.  Can you find a way to have the user provide the private data buffer when retrieving a connection event that contains private data?  This might complicate things due to not knowing how much private data is available.

>>>        // IWVDatagramQueuePair Methods
>>>        STDMETHOD(Send)(
>>>                THIS_
>>>                __in UINT64 WrId,
>>>                __in IWVAddressHandle* pAddressHandle,
>>>                __in WV_SGE* pSgl,
>>
>>Only one SGE allowed?  If so, name it as pSge rather than pSgl.  Otherwise
>>you're missing the nSge parameter.
>
>For this call, only 1 SGE is allowed.  The intent is to provide a simpler
>interface for what I'm guessing would be the common usage model.  The
>SendMessage() method allows for multiple SGEs, as well as additional send
>operation control (inline, immediate data, completion notification, etc.).

On the topic of inline data, is there a requirement that the inline attribute be applied to a whole request vs. on a per-SGE basis?  Setting the LKey to zero could indicate an inline SGE.

Thoughts?

-Fab