[ofw] [RFC] [PATCH] openib.def: set build defaults

Sean Hefty sean.hefty at intel.com
Thu Feb 28 11:35:13 PST 2008


Set default values for build environment variables.  This allows someone
to just download the SVN tree and type 'build' to get the tree to build.
Both default values can be overridden by the user.

Signed-off-by: Sean Hefty <sean.hefty at intel.com>
---
The OPENIB_REV can always be set properly for WinOF releases, but there's
no guarantee that the value entered by a developer matches the SVN release
number.  This simply provides a default value of 0 - meaning, I don't
know, don't care, or the SVN number doesn't apply (such as building an
out of tree branch).

I selected a default platform SDK path based on what it ended up as on
my system.  It would be nice if others could see if this ends up being
a common default path, or if there really isn't a reasonable default
value.  If there is a decent default that we can set it to, then using
one could make life simpler for developers who just want to build the code.

Index: openib.def
===================================================================
--- openib.def	(revision 945)
+++ openib.def	(working copy)
@@ -12,21 +12,28 @@
 
 !IF !DEFINED(IB_MAJORVERSION)
 IB_MAJORVERSION=1
-!endif
+!ENDIF
 
 !IF !DEFINED(IB_MINORVERSION)
 IB_MINORVERSION=0
-!endif
+!ENDIF
 
 !IF !DEFINED(IB_FILEBUILD)
 IB_FILEBUILD=0
-!endif
+!ENDIF
 
+!IF !DEFINED(OPENIB_REV)
+OPENIB_REV=0
+!ENDIF
+
+!IF !DEFINED(PLATFORM_SDK_PATH)
+PLATFORM_SDK_PATH=c:\progra~1\mic977~1
+!ENDIF
+
 !IF !DEFINED(IB_FILEREV)
 IB_FILEREV=$(OPENIB_REV)
+!ENDIF
 
-!endif
-
 !IFNDEF VER_PROVIDER
 VER_PROVIDER="""OpenIB"""
 !ENDIF





More information about the ofw mailing list