[ofw] [PATCH] WSD: Only generate error output in case of error

Tzachi Dar tzachid at mellanox.co.il
Wed Jul 9 00:24:00 PDT 2008


Applied in 1351.

Thanks
Tzachi 

> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org 
> [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Fab Tillier
> Sent: Wednesday, July 09, 2008 3:37 AM
> To: ofw at lists.openfabrics.org
> Subject: [ofw] [PATCH] WSD: Only generate error output in 
> case of error
> 
> My previous patch to make WSD use IBAT generated error 
> logging even in successful cases.  This patch relocates the 
> error output into an 'else' clause.
> 
> Signed-off-by: Fab Tillier <ftillier at microsoft.com>
> 
> diff -up -r -X trunk\docs\dontdiff.txt -I \$Id: 
> old\ulp\wsd\user\ibsp_ip.c trunk\ulp\wsd\user\ibsp_ip.c
> --- old\ulp\wsd\user\ibsp_ip.c  Tue Jul 08 10:15:30 2008
> +++ trunk\ulp\wsd\user\ibsp_ip.c        Tue Jul 08 17:32:48 2008
> @@ -288,11 +288,14 @@ query_guid_address(
>                         Sleep( 100 );
>         }
>         if( hr == S_OK )
> +       {
>                 *port_guid = gids.dest_gid.unicast.interface_id;
> -
> -       IBSP_ERROR( ("IBAT::Resolve failed for IP %08x\n",
> -               ((struct 
> sockaddr_in*)p_dest_addr)->sin_addr.s_addr) );
> -
> +       }
> +       else
> +       {
> +               IBSP_ERROR( ("IBAT::Resolve for IP %08x\n",
> +                       ((struct 
> sockaddr_in*)p_dest_addr)->sin_addr.s_addr) );
> +       }
>         return hr;
>  }
> 
> 



More information about the ofw mailing list