[ofw] [PATCH] IBAL: Remove PD context from IOCTLs
Fab Tillier
ftillier at windows.microsoft.com
Fri Jul 11 15:57:19 PDT 2008
IBAL's ib_query_qp and ib_query_mw IOCTLs return the PD context in the output IOCTL buffer. It is however never referenced.
This patch removes the fields (which had been changed to TO_LONG_PTR).
Signed-off-by: Fab Tillier <ftillier at microsoft.com>
diff -up -r -X trunk\docs\dontdiff.txt -I \$Id: old\core\al\kernel\al_proxy_verbs.c trunk\core\al\kernel\al_proxy_verbs.c
--- old\core\al\kernel\al_proxy_verbs.c Fri Jul 11 14:51:55 2008
+++ trunk\core\al\kernel\al_proxy_verbs.c Fri Jul 11 15:47:31 2008
@@ -1772,17 +1772,11 @@ proxy_query_av(
goto proxy_query_av_err;
status = cpyout_umvbuf( &p_ioctl->out.umv_buf, p_umv_buf );
- if( status == IB_SUCCESS )
- {
- /* Return proxy's PD handle when AV was created */
- p_ioctl->out.pd_context = (void*)h_pd->obj.context;
- }
- else
+ if( status != IB_SUCCESS )
{
proxy_query_av_err:
p_ioctl->out.umv_buf = p_ioctl->in.umv_buf;
cl_memclr( &p_ioctl->out.attr, sizeof(ib_av_attr_t) );
- p_ioctl->out.pd_context = NULL;
}
free_umvbuf( p_umv_buf );
@@ -3419,18 +3413,10 @@ proxy_query_mw(
goto proxy_query_mw_err;
status = cpyout_umvbuf( &p_ioctl->out.umv_buf, p_umv_buf );
- if( status == IB_SUCCESS )
- {
- /*
- * replace the pd handle with user's pd context for the proxy's PD.
- */
- p_ioctl->out.pd_context = (void*)h_pd->obj.context;
- }
- else
+ if( status != IB_SUCCESS )
{
proxy_query_mw_err:
p_ioctl->out.umv_buf = p_ioctl->in.umv_buf;
- p_ioctl->out.pd_context = NULL;
p_ioctl->out.rkey = 0;
}
free_umvbuf( p_umv_buf );
Only in old\hw\mthca\kernel: mthca_log.rc
diff -up -r -X trunk\docs\dontdiff.txt -I \$Id: old\inc\iba\ib_al_ioctl.h trunk\inc\iba\ib_al_ioctl.h
--- old\inc\iba\ib_al_ioctl.h Fri Jul 11 14:51:55 2008
+++ trunk\inc\iba\ib_al_ioctl.h Fri Jul 11 15:47:31 2008
@@ -1,6 +1,7 @@
/*
* Copyright (c) 2005 SilverStorm Technologies. All rights reserved.
* Copyright (c) 1996-2003 Intel Corporation. All rights reserved.
+ * Portions Copyright (c) 2008 Microsoft Corporation. All rights reserved.
*
* This software is available to you under the OpenIB.org BSD license
* below:
@@ -561,7 +562,6 @@ typedef union _ual_query_av_ioctl
ci_umv_buf_t umv_buf;
ib_api_status_t status;
ib_av_attr_t attr;
- TO_LONG_PTR(void* , pd_context) ;
} out;
@@ -584,9 +584,6 @@ typedef union _ual_query_av_ioctl
*
* out.attr
* Attributes of the address vector.
-*
-* pd_context
-* Context associated with the PD when created.
*****/
@@ -1597,7 +1594,6 @@ typedef union _ual_query_mw_ioctl
{
ci_umv_buf_t umv_buf;
ib_api_status_t status;
- TO_LONG_PTR(void* , pd_context) ;
net32_t rkey;
} out;
@@ -1618,10 +1614,6 @@ typedef union _ual_query_mw_ioctl
*
* out.status
* Status of the operation.
-*
-* pd_context
-* This user-mode context for the protection domain
-* associated with the memory window.
*
* rkey
* RKey associated with the memory window.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pd_context.patch
Type: application/octet-stream
Size: 2779 bytes
Desc: pd_context.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080711/f44a56f0/attachment.obj>
More information about the ofw
mailing list