[ofw] [PATCH] Refine UAL_NDI_NOOP handler

Leonid Keller leonid at mellanox.co.il
Sun Jul 13 04:25:39 PDT 2008


Applied in 1391. Thank you. 

> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org 
> [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Fab Tillier
> Sent: Saturday, July 12, 2008 3:18 AM
> To: ofw at lists.openfabrics.org
> Subject: [ofw] [PATCH] Refine UAL_NDI_NOOP handler
> 
> The UAL_NDI_NOOP IOCTL handler was added to allow memory 
> registration in user-mode to notify a client using an I/O 
> completion port.  This patch extends the functionality to 
> allow the IOCTL to return either STATUS_SUCCESS or 
> STATUS_TIMEOUT.  The STATUS_TIMEOUT facility is used by the 
> NetworkDirect provider when IBAT returns pending.  It's 
> crude, but gets the job done.
> 
> I'll be looking at IPoIB and IBAT timeouts once all my 
> pending changes are sent/applied.
> 
> Signed-off-by: Fab Tillier <ftillier at microsoft.com>
> 
> diff -up -r -X trunk\docs\dontdiff.txt -I \$Id: 
> old\core\al\kernel\al_proxy_ndi.c trunk\core\al\kernel\al_proxy_ndi.c
> --- old\core\al\kernel\al_proxy_ndi.c   Fri Jul 11 17:13:15 2008
> +++ trunk\core\al\kernel\al_proxy_ndi.c Fri Jul 11 17:11:20 2008
> @@ -614,7 +614,10 @@ ndi_ioctl(
>                 cl_status = __ndi_dreq_cm( p_context, 
> h_ioctl, p_ret_bytes );
>                 break;
>      case UAL_NDI_NOOP:
> -        cl_status = CL_SUCCESS;
> +        if( cl_ioctl_in_size( h_ioctl ) != 0 )
> +            cl_status = STATUS_TIMEOUT;
> +        else
> +            cl_status = CL_SUCCESS;
>          break;
>         default:
>                 cl_status = CL_INVALID_PARAMETER;
> 



More information about the ofw mailing list