[ofw] [patch] srp -- remove checks against reserved fields

chas williams - CONTRACTOR chas.williams at cmf.nrl.navy.mil
Mon Jul 14 08:43:08 PDT 2008


according to revision 1.6a of the srp protocol document (see page 69),
the rdma transfer size and send message depth are both reserved fields.
therefore, windows should not be checking for correctness of these
values.

Index: srp_hba.c
===================================================================
--- srp_hba.c	(revision 1394)
+++ srp_hba.c	(working copy)
@@ -420,9 +420,7 @@
 	}
 
 	// Can it handle our IO requirements?
-	if ( cl_ntoh32( p_ioc_rec->info.profile.send_msg_size )  <  SRP_MIN_TGT_TO_INI_IU ||
-		 cl_ntoh16( p_ioc_rec->info.profile.send_msg_depth ) == 0 ||
-		 cl_ntoh32( p_ioc_rec->info.profile.rdma_size )      <  SRP_MIN_TGT_TO_INI_DMA )
+	if ( cl_ntoh32( p_ioc_rec->info.profile.send_msg_size )  <  SRP_MIN_TGT_TO_INI_IU )
 	{
 		SRP_PRINT_EXIT( TRACE_LEVEL_ERROR, SRP_DBG_ERROR,
 			("Device Not Capable.\n") );
Index: srp.h
===================================================================
--- srp.h	(revision 1394)
+++ srp.h	(working copy)
@@ -54,7 +54,6 @@
 
 #define SRP_MIN_INI_TO_TGT_IU       64      // Minimum initiator message size
 #define SRP_MIN_TGT_TO_INI_IU       56      // Minimum target message size
-#define SRP_MIN_TGT_TO_INI_DMA      512     // At least one sector!
 
 /* Requests sent from SRP initiator ports to SRP target ports */
 #define SRP_LOGIN_REQ   0x00



More information about the ofw mailing list