[ofw] RE: IPoIB partition patch

[Slava Strebkov]

Hi Tzachi,

Please see my answers below.

 

-----Original Message-----
From: Tzachi Dar [mailto:tzachid at mellanox.co.il] 
Sent: Wednesday, July 16, 2008 11:48 PM
To: Slava Strebkov
Cc: ofw at lists.openfabrics.org
Subject: RE: [ofw] RE: IPoIB partition patch

 

 

Hi Slava,

 

I have been looking at the partition patch and I have two questions:

 

1) The function bus_add_pkey can be called twice. Once from proxy_ioctl

and once from ioc_ioctl. I guess that one of them is redundant. Is that

true?

Yes, proxy_ioctl is redundant, sorry I forgot to remove. 

 

2) I have noticed that when entering guids I have to do a byte swap of

the GUID. That is if I look at the GUID as it is printed by vstat than I

have to do the swap manually. Is there any reason for that?

 

I took GUID from Device manager (device ID). That's the only reason for
byte swap.

 

Thanks

Tzachi

 

Thanks

Slava

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080717/f633df31/attachment.html>