[ofw] [PATCH] Coinstaller house keeping

Fab Tillier ftillier at windows.microsoft.com
Thu Jun 26 19:53:21 PDT 2008


This patch cleans up the includes for the HCA co-installer and corrects the version information to correctly identify the DLL as such (rather than as an executable).

Signed-off-by: Fab Tillier <ftillier at microsoft.com>

Index: tools/coinstaller/user/SOURCES
===================================================================
--- tools/coinstaller/user/SOURCES      (revision 1300)
+++ tools/coinstaller/user/SOURCES      (working copy)
@@ -10,14 +10,8 @@

 USE_MSVCRT=1

-#INCLUDES=$(PLATFORM_SDK_PATH)\include;\
-#      $(PLATFORM_SDK_PATH)\include\mfc
+INCLUDES=..\..\..\inc;

-INCLUDES=..\..\..\inc;..\..\..\inc\user;
-
-#INCLUDES= $(WINIBHOME)\inc;                    \
-#          $(WINIBHOME)\inc\user;
-
 C_DEFINES=$(C_DEFINES) -DUNICODE -D_UNICODE

 TARGETLIBS=$(SDK_LIB_PATH)\setupapi.lib        \
Index: tools/coinstaller/user/IBInstaller.rc
===================================================================
--- tools/coinstaller/user/IBInstaller.rc       (revision 1300)
+++ tools/coinstaller/user/IBInstaller.rc       (working copy)
@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2008 Mellanox Technologies.  All rights reserved.
+ * Portions Copyright (c) 2008 Microsoft Corporation.  All rights reserved.
  *
  * This software is available to you under the OpenIB.org BSD license
  * below:
@@ -31,7 +32,7 @@

 #include <oib_ver.h>

-#define VER_FILETYPE                           VFT_APP
+#define VER_FILETYPE                           VFT_DLL
 #define VER_FILESUBTYPE                                VFT2_UNKNOWN

 #if DBG
@@ -40,7 +41,7 @@
 #define VER_FILEDESCRIPTION_STR                "InfiniBand HCA Class Co-installer"
 #endif

-#define VER_INTERNALNAME_STR           "ibinstaller.exe"
-#define VER_ORIGINALFILENAME_STR       "ibinstaller.exe"
+#define VER_INTERNALNAME_STR           "ibinstaller.dll"
+#define VER_ORIGINALFILENAME_STR       "ibinstaller.dll"

 #include <common.ver>
\ No newline at end of file
-------------- next part --------------
A non-text attachment was scrubbed...
Name: coinstall.patch
Type: application/octet-stream
Size: 1630 bytes
Desc: coinstall.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080626/12395219/attachment.obj>


More information about the ofw mailing list