[ofw] [PATCH] Cleanup XXX_PTR64 use from IOU bus driver

Leonid Keller leonid at mellanox.co.il
Sun Jun 29 10:55:12 PDT 2008


Applied in 1308. Thank you. 

> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org 
> [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Fab Tillier
> Sent: Saturday, June 28, 2008 4:18 AM
> To: ofw at lists.openfabrics.org
> Subject: [ofw] [PATCH] Cleanup XXX_PTR64 use from IOU bus driver
> 
> This patch removes XXX_PTR64 and TO_ULONG_PTR macro usage in 
> the IOU bus driver.  It's a kernel driver and doesn't need 
> any padding as it will always have the same pointer size as 
> other kernel drivers.
> 
> Signed-off-by: Fab Tillier <ftillier at microsoft.com>
> 
> Index: core/iou/kernel/iou_ioc_mgr.h
> ===================================================================
> --- core/iou/kernel/iou_ioc_mgr.h       (revision 1300)
> +++ core/iou/kernel/iou_ioc_mgr.h       (working copy)
> @@ -1,5 +1,6 @@
>  /*
>   * Copyright (c) 2005 SilverStorm Technologies.  All rights reserved.
> + * Portions Copyright (c) 2008 Microsoft Corporation.  All 
> rights reserved.
>   *
>   * This software is available to you under the OpenIB.org BSD license
>   * below:
> @@ -46,8 +47,8 @@
> 
>         ib_al_ifc_t                                     ifc;
> 
> -TO_LONG_PTR(   ib_al_handle_t  ,                             
>   h_al) ;
> -TO_LONG_PTR(   ib_pnp_handle_t ,                             
>   h_pnp) ;        /* Handle for iou PnP events */
> +       ib_al_handle_t                          h_al;
> +       ib_pnp_handle_t                         h_pnp;  /* 
> Handle for iou PnP events */
> 
>         /* Attributes for this IOU. */
>         iou_ifc_data_t                          info;
> Index: core/iou/kernel/iou_ioc_mgr.c
> ===================================================================
> --- core/iou/kernel/iou_ioc_mgr.c       (revision 1300)
> +++ core/iou/kernel/iou_ioc_mgr.c       (working copy)
> @@ -1,5 +1,6 @@
>  /*
>   * Copyright (c) 2005 SilverStorm Technologies.  All rights reserved.
> + * Portions Copyright (c) 2008 Microsoft Corporation.  All 
> rights reserved.
>   *
>   * This software is available to you under the OpenIB.org BSD license
>   * below:
> @@ -422,7 +423,7 @@
>         IOU_ENTER( IOU_DBG_PNP );
> 
>         CL_ASSERT( p_pnp_rec );
> -       p_ioc_mgr = (ioc_mgr_t* VOID_PTR64)p_pnp_rec->pnp_context;
> +       p_ioc_mgr = (ioc_mgr_t*)p_pnp_rec->pnp_context;
> 
>         switch( p_pnp_rec->pnp_event )
>         {
> Index: core/iou/kernel/iou_driver.h
> ===================================================================
> --- core/iou/kernel/iou_driver.h        (revision 1300)
> +++ core/iou/kernel/iou_driver.h        (working copy)
> @@ -1,5 +1,6 @@
>  /*
>   * Copyright (c) 2005 SilverStorm Technologies.  All rights reserved.
> + * Portions Copyright (c) 2008 Microsoft Corporation.  All 
> rights reserved.
>   *
>   * This software is available to you under the OpenIB.org BSD license
>   * below:
> @@ -200,7 +201,7 @@
>         cl_list_item_t                  list_item;
> 
>         /* All reported PDOs are children of an HCA. */
> -TO_LONG_PTR(   ib_ca_handle_t ,                        h_ca) ;
> +       ib_ca_handle_t                  h_ca;
> 
>         /*
>          * CA GUID copy - in case we get IRPs after the CA
> 



More information about the ofw mailing list