[ofw] ConnectX driver code

[Smith, Stan]

Leonid Keller wrote:
>  A college of mine, AlexN is doing this work now.
> (I mean - the transition to WDK).
> He makes changes so as to keep the stack still buildable in DDK
> environment.

I was told ConnectX would not build in the DDK environment which was why
the entire
build in WDK adventure was started.

Why do we care about building the ConnectX\ branch in the DDK
environment?
MS has moved forward, we should also.

> I believe, any changes wrt transition to WDK, made in this branch,
> will help him to finish his work faster and we all will benefit from
> that. I would suggest you and all to publish the patches before
> committing, especially those, that are not suitable for DDK.
> There are several WDKs in use now, each with its new bugs.

Which version of WDK should we be using?

Publishing patches for review 'should' be standard operating procedure.

> It will take some time till we get assured that the WDK-built stack is
> stable and workable.
> So I see as worthy to keep the stack also DDK-buildable till then.

Why waste time making things buildable in the DDK when those changes
will just
 become extra baggage in the near future when we 'fully' transition to
WDK?
Building in the DDK is desirable, although not a requirement IMHO.

Stan.

> 
> Alex,
> Could you, please, comment on the DAPL patch below ?
> Do you have a solution, that leaves the code DDK compatible ?
> TIA
> 
>> -----Original Message-----
>> From: Smith, Stan [mailto:stan.smith at intel.com]
>> Sent: Tuesday, March 25, 2008 2:51 AM
>> To: Leonid Keller; Hefty, Sean; ofw at lists.openfabrics.org
>> Subject: RE: [ofw] ConnectX driver code
>> 
>> Leonid Keller wrote:
>>> The branch has been re-created.
>>> Enjoy ! :)
>> 
>> Thank you!
>> 
>> With your permission, may we treat this 'connectX\' branch as the
>> repository for WDK work? That's to say, fixes required to make
>> openib-windows stack build using the WDK build environment would be
>> committed here. I have fixes which allow DAPL to build correctly in
>> the WDK environment. 
>> 
>> Unfortunately the following DDK --> WDK change is not backwards
>> compatible? Perhaps this is not the best way to fix the problem of
>> not finding .defs file in $(OBJ_PATH)?
>>     DLLDEF=$O\udapl_exports.def change to -->
>> DLLDEF=$(OBJ_PATH)\$O\udapl_exports.def
>> 
>> Stan.
>> 
>>> 
>>>> -----Original Message-----
>>>> From: ofw-bounces at lists.openfabrics.org
>>>> [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Leonid
>>>> Keller Sent: Sunday, March 23, 2008 7:33 PM
>>>> To: Sean Hefty; ofw at lists.openfabrics.org
>>>> Subject: RE: [ofw] ConnectX driver code
>>>> 
>>>> Guys, the new driver uses EXACTLY the same IBAL interface like the
>>>> previous one (MTHCA)! There is NO essential changes neither in
>>>> IBAL nor in ULPs so far. I've put the new driver code to enable
>>>> its reviewing and evaluating. The readme file [attached this time]
>>>> contains the answers to most of your so far questions. [And, as
>>>> Tzachi wrote, with WinMerge one could have found all the changes
>>>> in a minute]  
>>>> 
>>>> After all this said: I'll re-create the branch after checking that
>>>> it gets built and works. 
>>>> 
>>>> 
>>>>> -----Original Message-----
>>>>> From: Sean Hefty [mailto:sean.hefty at intel.com]
>>>>> Sent: Friday, March 21, 2008 6:55 PM
>>>>> To: Hefty, Sean; Leonid Keller; ofw at lists.openfabrics.org
>>>>> Subject: RE: [ofw] ConnectX driver code
>>>>> 
>>>>>> Can you please re-create the branch, apply only the real changes
>>>>>> to the branch, and commit that, so we can understand what
>>>>>> exactly is changing?
>>>>> 
>>>>> To be clear, here's what I'm asking for:
>>>>> 
>>>>> 1. Move your local copy of branches\connectx off into some 'temp'
>>>>> location. 
>>>>> 2. svn delete branches\connectx from svn 3. From the trunk,
>>>>> create a new branch to branches\connectx.
>>>>>    TortoiseSVN does this by right clicking on trunk, and selecting
>>>>>    branch. If done correctly, you should see a simple 1-line svn
>>>>> log message. 
>>>>> 4. Move 'temp'\connectx\hw\mlx4 back to branches\connectx\ 5.
>>>>> svn add the hw\mlx4 directory and files back to svn 6. svn commit
>>>>> this change. 
>>>>> 
>>>>> If you have any changes outside of the mlx4 directory (e.g.
>>>>> hw\dirs file), you will need to copy those files back into the
>>>>> tree as well.  Each change set should be self-contained and
>>>>> committed separately. 
>>>>> 
>>>>> This will let us see what the real differences between the branch
>>>>> and the trunk are, makes it easier to pull specific change sets
>>>>> between branches, avoids changing every file in the tree, and will
>>>>> allow the branch to be merged back into the trunk in the future.
>>>>> 
>>>>> - Sean
>>>>> 
>>>>> 
>>>> 
>>> _______________________________________________
>>> ofw mailing list
>>> ofw at lists.openfabrics.org
>>> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw