[ofw] changes in tools\wsdinstall\user\installsp.c

[Fab Tillier]

Ahh, including stdlib caused the name conflict.

-----Original Message-----
From: ofw-bounces at lists.openfabrics.org [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Tzachi Dar
Sent: Tuesday, May 06, 2008 1:37 PM
To: Fab Tillier; ofw at lists.openfabrics.org
Subject: RE: [ofw] changes in tools\wsdinstall\user\installsp.c

Hi Fab,

Indeed this is "(again) to work around a development tool limitation".

It seems that with the old name the compiler doesn't like it that much
(X86 free build environment).

Here is what I receive when I rename the variable to errno again.

In any case you are welcomed to propose another solution.

Thanks
Tzachi


Q:\projinf3\trunk\tools\wsdinstall\user>build -cg
path contains nonexistant c:\program files\microsoft driver test
manager\control
ler\installer64, removing
BUILD: Compile and Link for x86
BUILD: Loading c:\winddk\6001.18001\build.dat...
BUILD: Computing Include file dependencies:
BUILD: Start time: Tue May 06 23:29:20 2008
BUILD: Examining q:\projinf3\trunk\tools\wsdinstall\user directory for
files to
compile.
BUILD: Saving c:\winddk\6001.18001\build.dat...
BUILD: Compiling and Linking q:\projinf3\trunk\tools\wsdinstall\user
directory
_NT_TARGET_VERSION SET TO WS03
Compiling - installsp.c
errors in directory q:\projinf3\trunk\tools\wsdinstall\user
q:\projinf3\trunk\tools\wsdinstall\user\installsp.c(507) : error C2373:
'_errno'
 : redefinition; different type modifiers
Linking Executable -
q:\projinf3\trunk\bin\user\objfre_wnet_x86\i386\installsp.e
xe
link : error LNK1181: cannot open input file
'q:\projinf3\trunk\tools\wsdinstall
\user\objfre_wnet_x86\i386\installsp.obj'
BUILD: Finish time: Tue May 06 23:30:11 2008
BUILD: Done

    3 files compiled - 1 Warning - 1 Error
    1 executable built - 1 Error

> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org
> [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Fab Tillier
> Sent: Tuesday, May 06, 2008 11:05 PM
> To: ofw at lists.openfabrics.org
> Subject: [ofw] changes in tools\wsdinstall\user\installsp.c
>
> The local variable errno was renamed to err_no.  This
> introduces changes to the source that as far as I can tell
> are not actually useful. What was the purpose of this change?
>  Is it (again) to work around a development tool limitation?
>
> Please stop introducing code changes unless they're actually
> useful, and if you must, separate cleanup into specific
> cleanup patches.
>
> -Fab
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
>
_______________________________________________
ofw mailing list
ofw at lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw