[ofw] please stop referencing internal development trees insvnlogmessages

Alex Estrin alex.estrin at qlogic.com
Tue May 20 11:44:50 PDT 2008


Also it would be great if suggested patches were generated against WinOF
tree as well,
otherwise patch based on internal tree is quite hard to apply and test
locally.

Thanks,
Alex.
> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org 
> [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Sean Hefty
> Sent: Tuesday, May 20, 2008 2:02 PM
> To: 'Leonid Keller'; Ishai Rabinovitz; ofw at lists.openfabrics.org
> Subject: RE: [ofw] please stop referencing internal 
> development trees insvnlogmessages
> 
> I understand the need for internal tools and processes, but 
> those should really be kept internal.  They're meaningless to 
> everyone else.  We really don't want every company modifying 
> code based on what tool they use or documenting changes with 
> references to inaccessible repositories.
> 
> If the problem is that SVN is too slow or inaccessible, let's 
> focus on fixing the problem.
> 
> 
> 
> >One more thing.
> >We usually add a patch in our tree, check it and then 
> suggest it to the 
> >community.
> >So it comes to WinOF several days later ...
> >
> >> -----Original Message-----
> >> From: Ishai Rabinovitz
> >> Sent: Tuesday, May 20, 2008 8:09 PM
> >> To: Sean Hefty; Leonid Keller; ofw at lists.openfabrics.org
> >> Subject: RE: [ofw] please stop referencing internal 
> development trees 
> >> in svnlogmessages
> >>
> >> We want to have a bi-directional pointers.
> >>
> >> I cannot see what is the problem with an internal remark 
> added to the 
> >> description.
> >>
> >> Ishai
> >>
> >> > -----Original Message-----
> >> > From: ofw-bounces at lists.openfabrics.org 
> >> > [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of 
> Sean Hefty
> >> > Sent: Tuesday, May 20, 2008 7:53 PM
> >> > To: Leonid Keller; ofw at lists.openfabrics.org
> >> > Subject: RE: [ofw] please stop referencing internal
> >> development trees
> >> > in svnlogmessages
> >> >
> >> > >I believe, that not only we (Mellanox) are using internal
> >> trees for
> >> > >development and testing.
> >> > >The mentioned referencing is very usefull for maintaining 
> >> > >synchronization between the internal and WINOF's tree.
> >> > >So my suggestion is as follows.
> >> > >Let we allow adding proprietory comments in some agreed
> >> > format to the
> >> > >end of log messages.
> >> > >Say,
> >> > >	[<company tag>: <text>]
> >> > >
> >> > >In this case, instead of (winib 1234), we'll put [MLNX: 1234]
> >> >
> >> > I can understand the issue with slow response.  But why not
> >> do this in
> >> > reverse?
> >> > I.e. have your internal tree reference the windows SVN 
> version, and 
> >> > not the other way around.
> >> >
> >> >
> >> > _______________________________________________
> >> > ofw mailing list
> >> > ofw at lists.openfabrics.org
> >> > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
> >> >
> 
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
> 



More information about the ofw mailing list