[ofw] RE: Patch: [ipoib] Limit the time that is being spent in a DPC(don't handle more than 128 packet at one recv call)

[Tzachi Dar]

Thanks for your effort in testing this patch. We will soon post a new
patch.
 
Thanks
Tzachi


________________________________

	From: Smith, Stan [mailto:stan.smith at intel.com] 
	Sent: Saturday, November 08, 2008 12:07 AM
	To: Tzachi Dar
	Cc: ofw at lists.openfabrics.org
	Subject: RE: Patch: [ipoib] Limit the time that is being spent
in a DPC(don't handle more than 128 packet at one recv call)
	
	
	Hello,
	  Testing this patch produces problems. SM node is running this
code.
	Problems defined as
	  1) IPoIB interfaces take approximately 20 seconds to get a
DHCP assigned IPv4 address assigned; long after installer is done.
	      Without patch, DHCP often has DHCP address assigned to
IPoIB interface before WinOF installer has finished.
	 
	  2) During WinOF uninstall phase, devman remove
@IBA\IPOIB...... command hangs indefinitely?
	     Additional uninstall invocations of devman remove {IPOIB &
HCA) all hang. I had to use task manager to kill devman process in order
to complete the uninstall.
	I removed the patch and rebuilt ipoib.sys, none of the above
problems were seen.
	 
	stan.

________________________________

	From: ofw-bounces at lists.openfabrics.org
[mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Tzachi Dar
	Sent: Thursday, November 06, 2008 12:38 PM
	To: ofw at lists.openfabrics.org
	Subject: [ofw] Patch: [ipoib] Limit the time that is being spent
in a DPC (don't handle more than 128 packet at one recv call)
	
	
	Windows doesn't allow one DPC to last more than 100us.
	 
	It seems that on windows 2008 this is being enforced.
	 
	As a result I have added a limit on the number of packets that
will be used for each DPC.
	After that we stop.
	 
	Hopefully, there won't be  a need to do more changes.
	 
	Thanks
	Tzachi
	 
	Index: Q:/projinf4/trunk/ulp/ipoib/kernel/ipoib_port.c
	
===================================================================
	--- Q:/projinf4/trunk/ulp/ipoib/kernel/ipoib_port.c (revision
3437)
	+++ Q:/projinf4/trunk/ulp/ipoib/kernel/ipoib_port.c (revision
3438)
	@@ -1666,7 +1666,7 @@
	   recv_cnt += __recv_mgr_filter( p_port, p_wc, &done_list,
&bad_list );
	   cl_perf_stop( &p_port->p_adapter->perf, FilterRecv );
	 
	- } while( !p_free );
	+ } while( !p_free && recv_cnt < 128);
	 
	  /* We're done looking at the endpoint map, release the
reference. */
	  cl_atomic_dec( &p_port->endpt_rdr );
	

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20081109/b1d2bc16/attachment.html>