[ofw] RE: Patch: [ipoib] Make sure that the dlid is zero if itisnot in the list.

[Tzachi Dar]

Hi Fab,

I have tried creating a patch based on the suggestion you have
mentioned.

On line 186 of  ipoib_endpoint.c I have changed the code from 

p_endpt->dlid1 = p_mcast_rec->p_member_rec->mlid;

To CL_ASSERT(p_endpt->dlid1 == 0);

However this assert has happened as soon as I have loaded the driver.

This might be because of a broadcast call, or something else, I'll debug
it tomorrow.

Please also note that if the dlid is not zero, this means that we will
crash, since we will try to remove things from the lists.

Thanks
Tzachi

> -----Original Message-----
> From: Fab Tillier [mailto:ftillier at windows.microsoft.com] 
> Sent: Tuesday, November 11, 2008 1:56 AM
> To: Sean Hefty; Tzachi Dar; Alex Estrin; ofw at lists.openfabrics.org
> Subject: RE: [ofw] RE: Patch: [ipoib] Make sure that the dlid 
> is zero if itisnot in the list.
> 
> >> So multicast endpoints shouldn't need to be in the LID 
> map, though I 
> >> can't imagine a reason why that would be problematic 
> (unless multiple 
> >> groups map to the same LID - though is that even possible?)
> >
> > I think multiple multicast groups can map to the same MLID, 
> and this 
> > is needed to support IPv6.
> 
> Ok, then line 186 of ipoib_endpoint.c needs to go away, and 
> lines 6084-6096 of ipoib_port.c probably do too (multicast 
> endpoints should never go in the LID map).
> 
> -Fab
>