[ofw] RE: ipoib_driver.c changes

[Tzachi Dar]

Sure!

Since we always answer the LINK_RATE immediately, we don't have to look
for this query when ipoib_resume_oids() is being called.

Thanks
Tzachi 

> -----Original Message-----
> From: Smith, Stan [mailto:stan.smith at intel.com] 
> Sent: Wednesday, October 15, 2008 8:08 PM
> To: Tzachi Dar
> Cc: ofw at lists.openfabrics.org
> Subject: ipoib_driver.c changes 
> 
> Hello,
>   In the last 
> branches\WOF2-0\trunk\ulp\ipoib\kernel\ipoib_driver.c commit, 
> the following was removed.
> Was this intended?  Just checking.
> 
> Thanks,
> 
> Stan.
> 
> --- ipoib_driver.c.svn-1634     2008-10-08 17:05:41.523067200 -0700
> +++ ipoib_driver.c      2008-10-15 09:13:34.642153600 -0700
> @@ -28,7 +28,7 @@
>   * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
>   * SOFTWARE.
>   *
> - * $Id: ipoib_driver.c 1634 2008-10-07 08:08:59Z tzachid $
> + * $Id: ipoib_driver.c 1649 2008-10-15 15:10:19Z tzachid $
>   */
> 
>  #include "limits.h"
> @@ -955,31 +955,7 @@
>                 IPOIB_PRINT( TRACE_LEVEL_INFORMATION,IPOIB_DBG_OID,
>                         ("Port %d received query for 
> OID_GEN_LINK_SPEED\n", port_num) );
>                 cl_obj_lock( &p_adapter->obj );
> -               switch( p_adapter->state )
> -               {
> -               case IB_PNP_PORT_ADD:
> -                       /* Mark the adapter as pending an OID */
> -                       p_adapter->pending_query = TRUE;
> -
> -                       /* Save the request parameters. */
> -                       p_adapter->query_oid = oid_info;
> -
> -                       IPOIB_PRINT( 
> TRACE_LEVEL_INFORMATION,IPOIB_DBG_OID,
> -                               ("Port %d returning 
> NDIS_STATUS_PENDING\n", port_num) );
> -                       status = NDIS_STATUS_PENDING;
> -                       break;
> -
> -               case IB_PNP_PORT_REMOVE:
> -                       IPOIB_PRINT( 
> TRACE_LEVEL_INFORMATION,IPOIB_DBG_OID,
> -                               ("Port %d returning 
> NDIS_STATUS_NOT_ACCEPTED\n", port_num) );
> -                       status = NDIS_STATUS_NOT_ACCEPTED;
> -                       break;
> -
> -               default:
> -                       CL_ASSERT( p_adapter->p_port );
> -                       info = p_adapter->rate;
> -                       break;
> -               }
> +               info = p_adapter->port_rate;
>                 cl_obj_unlock( &p_adapter->obj );
>                 break;
> 
> @@ -2016,11 +1992,6 @@
>         {
>                 switch( query_oid.oid )
>                 {
> -               case OID_GEN_LINK_SPEED:
> -                       ipoib_complete_query( p_adapter, &query_oid,
> -                               status, &p_adapter->rate, 
> sizeof(p_adapter->rate) );
> -                       break;
> -
>                 case OID_GEN_MEDIA_CONNECT_STATUS:
>                         info = NdisMediaStateConnected;
>                         ipoib_complete_query( p_adapter, 
> &query_oid, @@ -2028,8 +1999,7 @@
>                         break;
> 
>                 default:
> -                       CL_ASSERT( query_oid.oid == 
> OID_GEN_LINK_SPEED ||
> -                               query_oid.oid == 
> OID_GEN_MEDIA_CONNECT_STATUS );
> +                       CL_ASSERT( query_oid.oid == 
> + OID_GEN_MEDIA_CONNECT_STATUS );
>                         break;
>                 }
>         }
>