[ofw] RE: Is there a race in __endpt_mgr_add_local?

[Alex Estrin]

Yes, it should be guarded with port lock.

Thanks,
Alex. 

> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org 
> [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Fab Tillier
> Sent: Thursday, October 23, 2008 6:57 PM
> To: Tzachi Dar; ofw at lists.openfabrics.org
> Subject: [ofw] RE: Is there a race in __endpt_mgr_add_local?
> 
> It probably needs a lock.  I don't have access to my dev box 
> right now so can't look for sure.
> 
> -Fab
> 
> >From: ofw-bounces at lists.openfabrics.org
> >[mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Tzachi Dar
> >Sent: Thursday, October 23, 2008 3:51 PM
> >To: Fab Tillier; ofw at lists.openfabrics.org
> >Subject: [ofw] Is there a race in __endpt_mgr_add_local?
> >
> >Hi Fab,
> >
> >The function __endpt_mgr_add_local is being called from 
> __bcast_cb without the port lock being hold.
> >
> >It later calls __endpt_mgr_insert (again without the lock).
> >
> >I believe that this is a bug, is there anyone who disagrees?
> >
> >Thanks
> >Tzachi
> >
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
>