[ofw] [PATCH 1/3] IBAL (checksum): restoring vendor_specific field

Fab Tillier ftillier at windows.microsoft.com
Thu Sep 4 11:18:20 PDT 2008


Hi Xalex,

Thank you for doing this.

>  Index: D:/Windows/MLNX_WINOF_CSUM_ARBEL/inc/iba/ib_types.h
> =================================================================== ---
> @@ -10670,6 +10665,7 @@
>                         ib_net16_t              remote_lid;
>                         uint8_t                 remote_sl;
>                         uint8_t                 path_bits;
> +                       uint8_t                 csum_ok;
>
>                 }       ud;

Can you reserve the csum_ok bits in the recv_opt field rather than adding an extra field?  This opens up the possibility in the future to have checksum offload for RC connections without needing to change the interfaces further.  It also removes the need for drivers to clear the field if checksum isn't supported (since the unused bits in the recv_opt field should be cleared).

-Fab




More information about the ofw mailing list