[ofw] [PATCH 1/3] IBAL (checksum): restoring vendor_specific field

[Alex Estrin]

My impression of discussion from July 30th was that all agreed to
incorporate chksum value into receive options field.
That would fit best into architecture and no need to change WC
structure.

Thanks,
Alex.

> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org 
> [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Fab Tillier
> Sent: Monday, September 08, 2008 1:14 PM
> To: Tzachi Dar; Alex Naslednikov; ofw at lists.openfabrics.org
> Subject: RE: [ofw] [PATCH 1/3] IBAL (checksum): restoring 
> vendor_specific field
> 
> > Applied to trunk and branch.
> 
> I guess this means that the checksum values aren't going to 
> be encoded in the existing receive options field?
> 
> It would be really nice to get some feedback on comments made 
> to the list.  Just posting patches, waiting a week or so 
> without responding to questions, and then checking in doesn't 
> foster a sense of community and cooperation.
> 
> -Fab
> 
> >
> > Thanks
> > Tzachi
> >
> >> -----Original Message-----
> >> From: Alex Naslednikov
> >> Sent: Thursday, September 04, 2008 7:34 PM
> >> To: Tzachi Dar; ofw at lists.openfabrics.org
> >> Cc: Ishai Rabinovitz
> >> Subject: [ofw] [PATCH 1/3] IBAL (checksum): restoring
> >> vendor_specific field
> >>
> >> Signed-off by: xalex (Alexander Naslednikov)
> >> Index:
> >> D:/Windows/MLNX_WINOF_CSUM_ARBEL/ulp/opensm/user/include/iba/i
> >> b_types_extended.h
> >> ===================================================================
> >> ---
> >> D:/Windows/MLNX_WINOF_CSUM_ARBEL/ulp/opensm/user/include/iba/i
> >> b_types_extended.h    (revision 3104)
> >> +++
> >> D:/Windows/MLNX_WINOF_CSUM_ARBEL/ulp/opensm/user/include/iba/i
> >> b_types_extended.h    (revision 3105)
> >> @@ -2096,12 +2096,7 @@
> >>       ib_wc_type_t                    wc_type;
> >>
> >>       uint32_t                                length;
> >> -     struct {
> >> -             uint8_t                         vendor_specific;
> >> -             uint8_t                         csum_ok;
> >> -             uint16_t                        vendor_specific2;
> >> -             uint32_t                        vendor_specific3;
> >> -     };
> >> +     uint64_t                                vendor_specific;
> >>       ib_wc_status_t                  status;
> >>
> >>       union _wc_recv
> >> @@ -2122,6 +2117,7 @@
> >>                       ib_net16_t              remote_lid;
> >>                       uint8_t                 remote_sl;
> >>                       uint8_t                 path_bits;
> >> +                     uint8_t                 csum_ok;
> >>
> >>               }       ud;
> >>
> >> Index: D:/Windows/MLNX_WINOF_CSUM_ARBEL/inc/iba/ib_types.h
> >> ===================================================================
> >> --- D:/Windows/MLNX_WINOF_CSUM_ARBEL/inc/iba/ib_types.h
> >> (revision 3104)
> >> +++ D:/Windows/MLNX_WINOF_CSUM_ARBEL/inc/iba/ib_types.h
> >> (revision 3105)
> >> @@ -10644,12 +10644,7 @@
> >>       ib_wc_type_t                    wc_type;
> >>
> >>       uint32_t                                length;
> >> -     struct {
> >> -             uint8_t                         vendor_specific;
> >> -             uint8_t                         csum_ok;
> >> -             uint16_t                        vendor_specific2;
> >> -             uint32_t                        vendor_specific3;
> >> -     };
> >> +     uint64_t                                vendor_specific;
> >>       ib_wc_status_t                  status;
> >>
> >>       union _wc_recv
> >> @@ -10670,6 +10665,7 @@
> >>                       ib_net16_t              remote_lid;
> >>                       uint8_t                 remote_sl;
> >>                       uint8_t                 path_bits;
> >> +                     uint8_t                 csum_ok;
> >>
> >>               }       ud;
> >>
> > _______________________________________________
> > ofw mailing list
> > ofw at lists.openfabrics.org
> > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
>