[ofw] [mthca/mlx4] ChkSum bitfields mismatch?

Alex Estrin alex.estrin at qlogic.com
Tue Sep 9 05:47:12 PDT 2008


Hello,

It seem checksum bits for Ndis packet are mismatched
considering  result checksum value applying directly to
NDIS_TCP_IP_CHECKSUM_PACKET_INFO.

Index: mlx4/kernel/bus/inc/cq.h
===================================================================
--- mlx4/kernel/bus/inc/cq.h	(revision 1573)
+++ mlx4/kernel/bus/inc/cq.h	(working copy)
@@ -115,12 +115,12 @@
 };
 
 enum {	
-	MLX4_NdisPacketTcpChecksumFailed 	= 1 << 1,
-	MLX4_NdisPacketUdpChecksumFailed 	= 1 << 2,
-	MLX4_NdisPacketIpChecksumFailed 	= 1 << 3,
-	MLX4_NdisPacketTcpChecksumSucceeded = 1 << 4,
-	MLX4_NdisPacketUdpChecksumSucceeded = 1 << 5,
-	MLX4_NdisPacketIpChecksumSucceeded 	= 1 << 6
+	MLX4_NdisPacketTcpChecksumFailed 	= 1 << 0,
+	MLX4_NdisPacketUdpChecksumFailed 	= 1 << 1,
+	MLX4_NdisPacketIpChecksumFailed 	= 1 << 2,
+	MLX4_NdisPacketTcpChecksumSucceeded = 1 << 3,
+	MLX4_NdisPacketUdpChecksumSucceeded = 1 << 4,
+	MLX4_NdisPacketIpChecksumSucceeded 	= 1 << 5
 };
 
 static inline void mlx4_cq_arm(struct mlx4_cq *cq, u32 cmd,
Index: mthca/kernel/mthca_cq.c
===================================================================
--- mthca/kernel/mthca_cq.c	(revision 1573)
+++ mthca/kernel/mthca_cq.c	(working copy)
@@ -118,12 +118,12 @@
 };
 
 enum {	
-	MTHCA_NdisPacketTcpChecksumFailed 		= 1 << 1,
-	MTHCA_NdisPacketUdpChecksumFailed 		= 1 << 2,
-	MTHCA_NdisPacketIpChecksumFailed 		= 1 << 3,
-	MTHCA_NdisPacketTcpChecksumSucceeded 	= 1 << 4,
-	MTHCA_NdisPacketUdpChecksumSucceeded 	= 1 << 5,
-	MTHCA_NdisPacketIpChecksumSucceeded 	= 1 << 6
+	MTHCA_NdisPacketTcpChecksumFailed 		= 1 << 0,
+	MTHCA_NdisPacketUdpChecksumFailed 		= 1 << 1,
+	MTHCA_NdisPacketIpChecksumFailed 		= 1 << 2,
+	MTHCA_NdisPacketTcpChecksumSucceeded 	= 1 << 3,
+	MTHCA_NdisPacketUdpChecksumSucceeded 	= 1 << 4,
+	MTHCA_NdisPacketIpChecksumSucceeded 	= 1 << 5
 };
 
 struct mthca_cqe {



Please correct me if I've missed something.

Thanks,
Alex.



More information about the ofw mailing list