[ofw] RE: patch: Fix a BSOD on ipoib

[Tzachi Dar]

This should go to the trunk and to the release branch.
 
The two ptches look exactly the same to me.
 
Thanks
Tzachi

________________________________

From: Smith, Stan [mailto:stan.smith at intel.com] 
Sent: Wednesday, August 12, 2009 8:57 PM
To: Tzachi Dar; ofw at lists.openfabrics.org
Subject: RE: patch: Fix a BSOD on ipoib


Hello,
  To which svn branch is this patch targeted at? It does not apply to
the trunk\ulp/ipoib/kernel/ipoib_port.c ?
 
Hand patching produces the following; is this what you had intended?
 
diff U3
F:/openIB-windows-svn/WOF2-1/RC-4/ulp/ipoib/kernel/ipoib_port.c.orig
F:/openIB-windows-svn/WOF2-1/RC-4/ulp/ipoib/kernel/ipoib_port.c
--- F:/openIB-windows-svn/WOF2-1/RC-4/ulp/ipoib/kernel/ipoib_port.c.orig
Mon Jul 13 09:47:18 2009
+++ F:/openIB-windows-svn/WOF2-1/RC-4/ulp/ipoib/kernel/ipoib_port.c Wed
Aug 12 10:54:25 2009
@@ -4598,8 +4598,11 @@
    &p_port->p_local_endpt->gid_item );
   cl_qmap_remove_item( &p_port->endpt_mgr.mac_endpts,
    &p_port->p_local_endpt->mac_item );
-  cl_qmap_remove_item( &p_port->endpt_mgr.lid_endpts,
-   &p_port->p_local_endpt->lid_item );
+  if( p_port->p_local_endpt->dlid ) {
+   cl_qmap_remove_item( &p_port->endpt_mgr.lid_endpts,
+    &p_port->p_local_endpt->lid_item );
+   p_port->p_local_endpt->dlid = 0;
+  }
   
   cl_qlist_insert_head(
    &mc_list, &p_port->p_local_endpt->mac_item.pool_item.list_item );
@@ -5155,6 +5158,7 @@
   {
    cl_qmap_remove_item(
     &p_port->endpt_mgr.lid_endpts, &p_endpt->lid_item );
+   p_endpt->dlid = 0;
   }
 
   cl_obj_unlock( &p_port->obj );


________________________________

From: ofw-bounces at lists.openfabrics.org
[mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Tzachi Dar
Sent: Wednesday, August 12, 2009 1:44 AM
To: ofw at lists.openfabrics.org
Subject: [ofw] patch: Fix a BSOD on ipoib


The patch bellow fixes a BSOD that happens when restarting the opensm
more than once (if the local endpoint was not in the lid_endpts list).
 
Thanks
Tzachi
 
Index:
Q:/projMLNX_WinOF_2.0/MLNX_WinOF_2-0/ulp/ipoib/kernel/ipoib_port.c
===================================================================
--- Q:/projMLNX_WinOF_2.0/MLNX_WinOF_2-0/ulp/ipoib/kernel/ipoib_port.c
(revision 4634)
+++ Q:/projMLNX_WinOF_2.0/MLNX_WinOF_2-0/ulp/ipoib/kernel/ipoib_port.c
(revision 4635)
@@ -4596,8 +4596,12 @@
    &p_port->p_local_endpt->gid_item );
   cl_qmap_remove_item( &p_port->endpt_mgr.mac_endpts,
    &p_port->p_local_endpt->mac_item );
-  cl_qmap_remove_item( &p_port->endpt_mgr.lid_endpts,
-   &p_port->p_local_endpt->lid_item );
+   if( p_port->p_local_endpt->dlid ) {
+   cl_qmap_remove_item( &p_port->endpt_mgr.lid_endpts,
+    &p_port->p_local_endpt->lid_item );
+      p_port->p_local_endpt->dlid = 0;
+    }
+
   
   cl_qlist_insert_head(
    &mc_list, &p_port->p_local_endpt->mac_item.pool_item.list_item );
@@ -5153,6 +5157,8 @@
   {
    cl_qmap_remove_item(
     &p_port->endpt_mgr.lid_endpts, &p_endpt->lid_item );
+    p_endpt->dlid = 0;
+
   }
 
   cl_obj_unlock( &p_port->obj );

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20090812/34eb72d4/attachment.html>