[ofw] FW: Patch: [IPOIB] IPoIB PXE boot support: Clear remainder of chaddr

Smith, Stan stan.smith at intel.com
Mon Aug 17 15:58:48 PDT 2009


Tzachi Dar wrote:
> A small patch (attached, with commit message) against current WinOF,
> which removes trailing garbage bytes from the DHCP chaddr field when
> using a Windows DHCP server and the latest IPoIB PXE code.
>
> --- a/ulp/ipoib/kernel/ipoib_port.c
> +++ b/ulp/ipoib/kernel/ipoib_port.c
> @@ -2349,6 +2349,8 @@ __recv_dhcp(
>               RtlFillMemory(&p_cid[11], 12, 0);
>
>               RtlCopyMemory( p_dhcp->chaddr, &p_src->mac,
> sizeof(p_src->mac) );
> +             RtlFillMemory( &p_dhcp->chaddr[sizeof(p_src->mac)],
> +                            ( sizeof(p_dhcp->chaddr) -
> sizeof(p_src->mac) ), 0 );
>       }
>       IPOIB_EXIT( IPOIB_DBG_RECV );
>       return status;
>
> Thanks,
>
> Michael

Looks good and tests with no problems - granted it's only std tests which do not include PXE boot.

I'll commit to trunk & WinOF 2.1 branch.

Stan.



More information about the ofw mailing list