[ofw] [PATCH] srp_connection.c - unused formal argument - remove from function

[Leonid Keller]

Your patch is OK, assuming that SRP fix in 2605 is OK.
But as you can see from description of 2605, this patch has no relevance
to SRP at all.
The fix for SRP got into this patch by mistake. 
I will revert and re-commit.

But the said doesn't mean that this SRP fix is wrong.
It just hasn't been tested by us.
If you (or anybody) have a possibility to see, that SRP works OK with
this patch (as I believe it should), one can commit it once more both
with your patch.
)BTW: this patch was intended to help in multipath situation, when two
ports of the same HCA in SRP initiator are connected to two ports of the
same HCA in SRP target. Without it SRP target could not tell between two
connections to different initiator ports)

> -----Original Message-----
> From: ofw-bounces at lists.openfabrics.org 
> [mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Smith, Stan
> Sent: Monday, November 30, 2009 10:12 PM
> To: Tzachi Dar
> Cc: ofw at lists.openfabrics.org
> Subject: [ofw] [PATCH] srp_connection.c - unused formal 
> argument - remove from function
> 
> 
> Remove ca_guid from srp_init_connection() as it is no longer 
> referenced due to svn.2605.
> 
> Signed-off-by: stan smith <stan.smith at intel.com>
> 
> 
> --- a/ulp/srp/kernel/srp_connection.c   Mon Nov 30 12:03:14 2009
> +++ b/ulp/srp/kernel/srp_connection.c   Mon Nov 30 11:22:18 2009
> @@ -699,7 +699,6 @@
> 
>  @param p_connection   - pointer to the connection structure
>  @param p_profile      - Pointer to IOC profile.
> - at param ca_guid        - Local CA GUID to use in as initiator GUID.
>  @param ext_id         - Initiator and target extension ID.
>  @param p_path_rec     - pointer to the path to the target
>  @param service_id     - service id to which we want to connect
> @@ -710,7 +709,6 @@
>  srp_init_connection(
>         IN      OUT     srp_connection_t                *p_connection,
>         IN              ib_ioc_profile_t* const p_profile,
> -       IN              net64_t                               
>   ca_guid,
>         IN              net64_t                               
>   ext_id,
>         IN      ib_path_rec_t           *p_path_rec,
>         IN              ib_net64_t                            
>   service_id )
> 
> 
> --- a/ulp/srp/kernel/srp_connection.h   Mon Nov 30 12:03:43 2009
> +++ b/ulp/srp/kernel/srp_connection.h   Mon Nov 30 11:22:14 2009
> @@ -102,7 +102,6 @@
>  srp_init_connection(
>         IN OUT  srp_connection_t        *p_connection,
>         IN              ib_ioc_profile_t* const p_profile,
> -       IN              net64_t                               
>   ca_guid,
>         IN              net64_t                               
>   ext_id,
>         IN      ib_path_rec_t           *p_path_rec,
>         IN      ib_net64_t              service_id );
> 
> 
> --- a/ulp/srp/kernel/srp_session.c      Mon Nov 30 12:04:15 2009
> +++ b/ulp/srp/kernel/srp_session.c      Mon Nov 30 11:21:39 2009
> @@ -277,7 +277,6 @@
> 
>         *p_status = srp_init_connection( &p_srp_session->connection,
>                                                               
>           &p_hba->ioc_info.profile,
> -                                                             
>           p_hba->info.ca_guid,
>                                                               
>           target_id_extension,
>                                                               
>           p_path_rec,
>                                                               
>           p_svc_entry->id );
> 
> _______________________________________________
> ofw mailing list
> ofw at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ofw
>