[ofw] RE: PATCH: Fix error handling of mlx4_bus driver.

Fab Tillier ftillier at windows.microsoft.com
Mon Feb 9 10:06:42 PST 2009


>Index: Q:/projinf2/trunk/hw/mlx4/kernel/bus/core/device.c
>===================================================================
>--- Q:/projinf2/trunk/hw/mlx4/kernel/bus/core/device.c (revision 3919)
>+++ Q:/projinf2/trunk/hw/mlx4/kernel/bus/core/device.c (revision 3920)
>@@ -332,6 +332,11 @@
>  struct ib_client_data *context, *tmp;
>  unsigned long flags;
>
>+ if(device->reg_state != IB_DEV_REGISTERED) {
>+  ASSERT(FALSE);

This would be better as ASSERT( device->reg_state == IB_DEV_REGISTERED ) - that makes the assertion message a little clearer, and will have the same effect.

>+  return;
>+ }
>+



More information about the ofw mailing list