[ofw] [ib-diag] sminfo: add support for WinOF

Sasha Khapyorsky sashak at voltaire.com
Sat Feb 14 07:40:45 PST 2009


On 10:39 Fri 13 Feb     , Sean Hefty wrote:
> >diff --git a/infiniband-diags/src/ibdiag_common.c b/infiniband-
> >diags/src/ibdiag_common.c
> >index bda1efa..154e00c 100644
> >--- a/infiniband-diags/src/ibdiag_common.c
> >+++ b/infiniband-diags/src/ibdiag_common.c
> >@@ -43,15 +43,14 @@
> > #include <stdlib.h>
> > #include <stdarg.h>
> > #include <sys/types.h>
> >-#include <unistd.h>
> > #include <ctype.h>
> >-#include <config.h>
> > #include <getopt.h>
> >
> > #include <infiniband/umad.h>
> > #include <infiniband/mad.h>
> > #include <ibdiag_common.h>
> > #include <ibdiag_version.h>
> >+#include "ibdiag_osd.h"
> 
> I think it'll be easier to just put this include in ibdiag_common.h...

What about to add files inttypes.h and unistd.h in winof tree? It could
be wrapper similars to ibdiag_osd.h.

Sasha

> 
> >diff --git a/infiniband-diags/src/sminfo.c b/infiniband-diags/src/sminfo.c
> >index e96c782..7767668 100644
> >--- a/infiniband-diags/src/sminfo.c
> >+++ b/infiniband-diags/src/sminfo.c
> >@@ -37,14 +37,13 @@
> >
> > #include <stdio.h>
> > #include <stdlib.h>
> >-#include <unistd.h>
> >-#include <inttypes.h>
> > #include <getopt.h>
> >
> > #include <infiniband/umad.h>
> > #include <infiniband/mad.h>
> >
> > #include "ibdiag_common.h"
> >+#include "ibdiag_osd.h"
> 
> ...and avoid adding it to all the source files.  I'll update my patches, but
> wait for comments against this patch before re-submitting.
> 
> - Sean
> 



More information about the ofw mailing list