[ofw] RE: [ofa-general] [PATCH 1/3 v2] libibmad. 2nd revision for WinOF portablity.

[Davis, Arlin R]

>The patches (I tried to check only 1 and 2) are malformed - whitespaces
>are mangled (in 2), also long lines are broken. Please check that it is
>appliable with 'git am'.

Sorry, I was just upgrade to exchange server 2007. Need I say more.
Patches attached as separate files.

>Is it possible to preserve c99 stuff? It improves code maintainability
>a lot and as far as I remember it is what was considered in previous
>discussions (about infiniband-diags porting to WinOF).

Like Sean said, until WinOF changes the build enviroment we have
no choice. The majority of the changes went into field.c and given
the structure includes a character field with the mad field name 
I would think maintainability is preserved. I added your recent
PortXmitWait and CounterSelect2 changes with no problem.
 
>
>Something not related to porting...
>
>I would rather replace all '#include <mad.h>' occurrences to
>'#include <infiniband/mad.h>' and then use '-I$(srcdir)/include' in
>INCLUDES definition.
>

No problem.

>And if file is listed in library_HEADERS it will be distributed, so no
>need to list it in EXTRA_DIST (of course mad.h should be remove too).
>

Ok.

 
>> -#include <stdint.h>
>> -#include <string.h>
>> -#include <stdlib.h>
>> -#include <stdio.h>
>> -#include <sys/types.h>
>> -#include <unistd.h>
>> -#include <byteswap.h>
>> +#include <infiniband/mad_osd.h>
>
>Why should we remove all header files here? Some of them (such as
>stdio.h) are not really system dependent.

We can keep these in mad.h. Just thinking beyond windows/linux.

-arlin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Minor-changes-to-source-to-allow-portability-to-WinO.patch
Type: application/octet-stream
Size: 9465 bytes
Desc: 0003-Minor-changes-to-source-to-allow-portability-to-WinO.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20090120/70bfd2fb/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libibmad-add-os-dependent-definitions.patch
Type: application/octet-stream
Size: 14485 bytes
Desc: 0001-libibmad-add-os-dependent-definitions.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20090120/70bfd2fb/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-remove-c99-definitions-within-the-ib_mad_f-structure.patch
Type: application/octet-stream
Size: 27448 bytes
Desc: 0002-remove-c99-definitions-within-the-ib_mad_f-structure.patch
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20090120/70bfd2fb/attachment-0002.obj>