[ofw] RE: ndinstall patch
Sean Hefty
sean.hefty at intel.com
Thu Jul 16 15:06:12 PDT 2009
>-int index;
>+#define DEFAULT_PROVIDER_INDEX IBAL_INDEX
>+
>+int index=DEFAULT_PROVIDER_INDEX;
I'm fine if you want to change the name here. In any case, I should have
defined it as static, so it wouldn't hurt to do that since we're changing the
line anyway.
>@@ -257,6 +271,9 @@
> {
> int i;
>
>+ if ( !name )
>+ return 0; /* assumes global 'index' set to default provider
index.
Maybe I wasn't clear. We should only need 1 set of these changes. The change
above or the two below.
> case 'i':
>- if (install || remove || get_prov_index(optarg)) {
>+ if (install || remove || (optarg &&
get_prov_index(optarg)))
>{
> goto usage;
> }
> install = 1;
> break;
> case 'r':
>- if (install || remove || get_prov_index(optarg)) {
>+ if (install || remove || (optarg &&
get_prov_index(optarg)))
More information about the ofw
mailing list