[ofw] RE: Allow hw\mlx4\kernel\bus\drv\pci.c to compile without warnings

[Smith, Stan]

Sounds like the correct resolution.
Glad you caught this one.

Stan.

-----Original Message-----
From: Leonid Keller [mailto:leonid at mellanox.co.il]
Sent: Tuesday, June 16, 2009 1:30 AM
To: Leonid Keller; Smith, Stan; Hefty, Sean
Cc: ofw at lists.openfabrics.org
Subject: RE: Allow hw\mlx4\kernel\bus\drv\pci.c to compile without warnings

The previous mail was sent under (wrong) impression, that you've fixed
the problem.
After second look I understood, that this print is not only superfluous,
but also misplaced.
It is put after vpd release and is to cause a crash.
So I removed the print at all (Svn.2256)

> -----Original Message-----
> From: Leonid Keller
> Sent: Tuesday, June 16, 2009 10:38 AM
> To: 'Smith, Stan'; Hefty, Sean
> Cc: ofw at lists.openfabrics.org
> Subject: RE: Allow hw\mlx4\kernel\bus\drv\pci.c to compile
> without warnings
>
> Thank you.
>
> > -----Original Message-----
> > From: Smith, Stan [mailto:stan.smith at intel.com]
> > Sent: Tuesday, June 16, 2009 12:52 AM
> > To: Hefty, Sean; Leonid Keller
> > Cc: ofw at lists.openfabrics.org
> > Subject: RE: Allow hw\mlx4\kernel\bus\drv\pci.c to compile without
> > warnings
> >
> > Svn.2255
> >
> > -----Original Message-----
> > From: Hefty, Sean
> > Sent: Monday, June 15, 2009 2:44 PM
> > To: Smith, Stan; Leonid Keller
> > Cc: ofw at lists.openfabrics.org
> > Subject: RE: Allow hw\mlx4\kernel\bus\drv\pci.c to compile without
> > warnings
> >
> > >  pci.c @ line 556 needs a (char*) cast on &vpd[3] in order
> > to build in
> > >the x64 build environment without warnings which kill the build.
> > >
> > >Stan.
> > >
> > >556c556,557
> > ><                       ("Found VPD of size %d, beginning
> > with '%s'\n",
> > >*p_vpd_size, &vpd[3]));
> > >---
> > >>                       ("Found VPD of size %d, beginning
> > with '%s'\n",
> > >>                       *p_vpd_size, (char*)&vpd[3]));
> >
> > What is vpd array, and why is it being used as a string if it isn't
> > already char *?  (I don't see this in my tree, but I
> haven't updated
> > in a couple of days.)
> >
> >